feat: add CSV file IDs to adapter v1 for form runner integration#183
Merged
whitewaterdesign merged 6 commits intomainfrom Sep 2, 2025
Merged
feat: add CSV file IDs to adapter v1 for form runner integration#183whitewaterdesign merged 6 commits intomainfrom
whitewaterdesign merged 6 commits intomainfrom
Conversation
whitewaterdesign
approved these changes
Sep 1, 2025
Contributor
whitewaterdesign
left a comment
whitewaterdesign
left a comment
There was a problem hiding this comment.
Looks good - have added a bit myself
alexluckett
reviewed
Sep 1, 2025
Comment on lines
+48
to
+49
| formId: formMetadata?.id ?? '', | ||
| formSlug: formMetadata?.slug ?? '', |
Contributor
There was a problem hiding this comment.
out of scope of the PR but why would these ever be null/undefined?
alexluckett
approved these changes
Sep 1, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Jira ticket:
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).