Accept new class for cache service input#189
Merged
alexluckett merged 8 commits intofeat/DF-370-save-progressfrom Sep 8, 2025
Merged
Accept new class for cache service input#189alexluckett merged 8 commits intofeat/DF-370-save-progressfrom
alexluckett merged 8 commits intofeat/DF-370-save-progressfrom
Conversation
alexluckett
force-pushed
the
feature/injectable-cache-service
branch
from
b86b65e to
462993c
Compare
davidjamesstone
force-pushed
the
feat/DF-370-save-progress-config
branch
from
dc857a3 to
762f4cd
Compare
Base automatically changed from
feat/DF-370-save-progress-config
to
feat/DF-370-save-progress
September 4, 2025 08:26
alexluckett
force-pushed
the
feature/injectable-cache-service
branch
from
b7f2b5f to
306c24f
Compare
davidjamesstone
force-pushed
the
feat/DF-370-save-progress
branch
from
55accfe to
f426d14
Compare
alexluckett
force-pushed
the
feature/injectable-cache-service
branch
from
8fbda5a to
fb2a0f0
Compare
alexluckett
force-pushed
the
feature/injectable-cache-service
branch
from
fb2a0f0 to
932335d
Compare
|
| * @param {ADDITIONAL_IDENTIFIER} [_additionalIdentifier] | ||
| * @returns | ||
| */ | ||
| Key(_request, _additionalIdentifier) { |
Contributor
There was a problem hiding this comment.
Just wondering why this is pascal?
Contributor
Author
There was a problem hiding this comment.
Legacy reasons, it's always been like that for some reason. Worth us changing soon, I'll leave it for now until the dust has settled on these PRs.
whitewaterdesign
approved these changes
Sep 8, 2025
Contributor
whitewaterdesign
left a comment
whitewaterdesign
left a comment
There was a problem hiding this comment.
Looks good to me 👍
davidjamesstone
added a commit
that referenced
this pull request
Sep 8, 2025
* Renamed saveAndReturn to saveAndExit * Further rename to saveAndExit * Line ending * Update save and exit config options (#187) * Export plugin schema * Update save and exit options * Update save and exit configuration options * Update cacheService to remove old save and exit implementation * Update save and exit tests * Update save and exit docs * Remove old save and return exit page * Add FormResponseToolkit for convenience * Refactor to use new FormResponseToolkit * Add and export "AnyRequest" type * Add, export and use "AnyFormRequest" type * Add docs on restoring a saved session * Allow Save and Exit from the summary page * Accept new class for cache service input (#189) * Renamed saveAndReturn to saveAndExit * Further rename to saveAndExit * Accept new class for cache service input * Accept a CacheService instance instead of a cache name * Export CacheService * use kebab case to align cache service with file form service * Add trailing newline to satisfy editorconfig * Fix state leakage between tests --------- Co-authored-by: Jez Barnsley <jbarnsley.github@gmail.com> * chore(release): #major --------- Co-authored-by: David Stone <davidjamesstone@gmail.com> Co-authored-by: Alex Luckett <alexluckett@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds a new cache service option to the plugin. Useful for overriding the cache Key, setState, etc.
Jira ticket:
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).