Skip to content

DF 330 - confirmation email to user#212

Merged
jbarnsley10 merged 26 commits intomainfrom
feat/DF-330-citizen-email
Oct 9, 2025
Merged

DF 330 - confirmation email to user#212
jbarnsley10 merged 26 commits intomainfrom
feat/DF-330-citizen-email

Conversation

@jbarnsley10
Copy link
Copy Markdown
Contributor

@jbarnsley10 jbarnsley10 commented Oct 3, 2025

Proposed change

Confirmation email to user

  • changed OutputService interface to allow a confirmation email address

Jira ticket: DF-330

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Misc. (documentation, build updates, etc)

Checklist

  • You have executed this code locally and it performs as expected.
  • You have added tests to verify your code works.
  • You have added code comments and JSDoc, where appropriate.
  • There is no commented-out code.
  • You have added developer docs in README.md and docs/* (where appropriate, e.g. new features).
  • The tests are passing (npm run test).
  • The linting checks are passing (npm run lint).
  • The code has been formatted (npm run format).

@jbarnsley10 jbarnsley10 marked this pull request as ready for review October 3, 2025 14:08
Comment thread src/server/plugins/engine/pageControllers/SummaryPageController.ts Outdated
Comment thread src/server/plugins/engine/pageControllers/SummaryPageController.ts Outdated
Comment thread src/server/plugins/engine/pageControllers/SummaryPageController.ts Outdated
Comment thread src/server/plugins/engine/types/schema.ts Outdated
Comment thread src/server/plugins/engine/types.ts Outdated
Comment thread src/server/plugins/engine/types/schema.ts Outdated
Copy link
Copy Markdown
Contributor

@whitewaterdesign whitewaterdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, don't have an issue with the Joi check

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 9, 2025

@jbarnsley10 jbarnsley10 merged commit 79f0e41 into main Oct 9, 2025
9 checks passed
@jbarnsley10 jbarnsley10 deleted the feat/DF-330-citizen-email branch October 9, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants