Move onRequest from prehandler to get and post handlers#214
Merged
alexluckett merged 19 commits intomainfrom Oct 20, 2025
Merged
Move onRequest from prehandler to get and post handlers#214alexluckett merged 19 commits intomainfrom
alexluckett merged 19 commits intomainfrom
Conversation
davidjamesstone
approved these changes
Oct 17, 2025
…es and update tests
- Introduced tests for redirectOrMakeHandler to validate onRequest callback functionality and response handling. - Added tests for repeater item-delete and summary routes to ensure correct route configuration and handler creation with onRequest callbacks. - Enhanced existing tests for makeGetHandler and makePostHandler to verify onRequest callback passing.
2d96c95 to
22a86d0
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Proposed change
PoC: Move onRequest logic to request-time handler in DXT plugin
This PR moves the onRequest callback from makeLoadFormPreHandler (pre-handler) to redirectOrMakeHandler (request-time handler), allowing request-specific logic to access the fully-initialised FormContext and page state.
Key changes:
Why:
Jira ticket: https://eaflood.atlassian.net/browse/TGC-844
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).