Skip to content

feature/DF-511: Postcode lookup #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidjamesstone merged 101 commits into from
Oct 20, 2025
Merged

feature/DF-511: Postcode lookup #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
101 commits
Select commit Hold shift + click to select a range
9b5e0c1
POC external components
alexluckett Oct 6, 2025
0d1ddb3
external components should work even if not in error state
alexluckett Oct 7, 2025
881535d
Improved typing
alexluckett Oct 7, 2025
e798f38
Use yar.flash rather than redirects to avoid user manipulation
alexluckett Oct 9, 2025
77c7be7
Move external component into shared macro
alexluckett Oct 9, 2025
0de6735
add error message support to external components
alexluckett Oct 9, 2025
b4dcf20
Postcode lookup configuration
davidjamesstone Oct 8, 2025
b2fd01b
Add postcode lookup plugin
davidjamesstone Oct 8, 2025
20602e3
Use local types location
davidjamesstone Oct 8, 2025
d9ec21e
Sonar fix (const duplicate)
davidjamesstone Oct 8, 2025
f13f304
Sonar fix (const duplicate)
davidjamesstone Oct 8, 2025
e6d4d68
Sonar fixes (Functional complexity)
davidjamesstone Oct 8, 2025
55ae28b
Sonar fixes (Functional complexity)
davidjamesstone Oct 8, 2025
68dbdaf
Sonar fixes (useless assignment)
davidjamesstone Oct 8, 2025
500cbd2
Sonar fixes (declared in the upper scope)
davidjamesstone Oct 8, 2025
5325f9b
Sonar fixes (nested template literals)
davidjamesstone Oct 8, 2025
c026c8e
Sonar fixes (variable in upper scope)
davidjamesstone Oct 8, 2025
1e6b77f
Sonar fixes (variable in upper scope)
davidjamesstone Oct 8, 2025
94c1082
Sonar fixes (function line length)
davidjamesstone Oct 8, 2025
89a6027
Sonar fixes (function line length)
davidjamesstone Oct 8, 2025
5733036
Sonar fixes (remove this commented out code)
davidjamesstone Oct 8, 2025
02288ae
Bump @defra/forms-model to v3.0.560
davidjamesstone Oct 8, 2025
f764b64
Show address hint text on the source page
davidjamesstone Oct 9, 2025
712640d
Add hint to the manual entry form
davidjamesstone Oct 9, 2025
2ff6f5e
Format address lowercase and include village (DEPENDENT_LOCALITY)
davidjamesstone Oct 9, 2025
6bebdea
Fix building number type
davidjamesstone Oct 9, 2025
ad0da3f
Consistent link placement
davidjamesstone Oct 9, 2025
9f30f40
Back links
davidjamesstone Oct 9, 2025
aa7d58e
Manual address field widths
davidjamesstone Oct 9, 2025
6b0d9cb
Clear stored postcode lookup session state on entering a new journey
davidjamesstone Oct 10, 2025
041f388
Handle OS service exceptions
davidjamesstone Oct 10, 2025
5cc8595
Trim inputs
davidjamesstone Oct 10, 2025
8c20015
Add UPRN to state
davidjamesstone Oct 10, 2025
74bed9e
Empty
davidjamesstone Oct 13, 2025
5953759
Add ExternalAction types
davidjamesstone Oct 14, 2025
9165e44
Add button styled as a link
davidjamesstone Oct 14, 2025
817f423
Remove enginePluginOptions from postcode plugin
davidjamesstone Oct 14, 2025
40e26d0
Remove lookup hrefs from address component
davidjamesstone Oct 14, 2025
8c01ca4
Add ExternalAction handlng
davidjamesstone Oct 14, 2025
823cc84
Remove loadFormPreHandler from postcode lookup routes
davidjamesstone Oct 14, 2025
32a2d8b
Update postcode lookup plugin to us external actions
davidjamesstone Oct 14, 2025
0aae016
Update postcode lookup types
davidjamesstone Oct 14, 2025
d8d0458
Sonar fixes (define a constant)
davidjamesstone Oct 14, 2025
2c1d68a
Sonar fixes (cognitive complexity)
davidjamesstone Oct 14, 2025
1191572
Remove unused import
davidjamesstone Oct 14, 2025
2692049
Add postcode lookup service tests
davidjamesstone Oct 14, 2025
ce2d1ce
Exclude stubs from Sonar
davidjamesstone Oct 14, 2025
a7ccf89
Add UPRN to UKAddress tests
davidjamesstone Oct 14, 2025
52fa40b
Add postcode service tests
davidjamesstone Oct 14, 2025
f1830d5
Revert "Add postcode service tests"
davidjamesstone Oct 14, 2025
e7e8bac
Fix package-lock.json
davidjamesstone Oct 14, 2025
d766654
Remove ununsed property in FormModel
davidjamesstone Oct 14, 2025
fe39e14
Revert "Remove ununsed property in FormModel"
davidjamesstone Oct 14, 2025
df277e8
Add postcode GET tests
davidjamesstone Oct 15, 2025
def788f
Update postcode lookup stubs
davidjamesstone Oct 15, 2025
4d006aa
Update postcode lookup tests
davidjamesstone Oct 15, 2025
97bfe18
Add test for when no addresses are found
davidjamesstone Oct 15, 2025
5c17350
Sonar issue (unexpected negated condition)
davidjamesstone Oct 15, 2025
bc5ca1e
Sonar fixes
davidjamesstone Oct 15, 2025
0cdf910
Sonar fix
davidjamesstone Oct 15, 2025
33009ac
Merge branch 'poc/external-components' into feature/DF-511-postcode-l…
davidjamesstone Oct 15, 2025
13e8909
Remove CustomerReferenceField example
davidjamesstone Oct 15, 2025
7102a57
Remove external getRoutes
davidjamesstone Oct 16, 2025
5229225
Add External types
davidjamesstone Oct 16, 2025
f1c6265
Replace getRoutes with dispatcher
davidjamesstone Oct 16, 2025
d40706f
Remove CustomerReferenceField
davidjamesstone Oct 16, 2025
53af5ab
Add dispatcher to UKAddressField
davidjamesstone Oct 16, 2025
5a2d3cf
Remove CustomerReferenceField
davidjamesstone Oct 16, 2025
06aae72
Update external action attribute name
davidjamesstone Oct 16, 2025
2e35d3a
Remove payload from PostcodeLookupDispatchData
davidjamesstone Oct 16, 2025
c6533af
Flash external component state
davidjamesstone Oct 16, 2025
b7422e1
Update to use importExternalComponentState
davidjamesstone Oct 16, 2025
5793ec6
Dispatch to external journey
davidjamesstone Oct 16, 2025
155cdf5
Merge pull request #220 from DEFRA/feature/DF-511-postcode-lookup-final
davidjamesstone Oct 16, 2025
5f1f320
Sonar fixes (Remove unnecessary Promise.resolve)
davidjamesstone Oct 16, 2025
3e1211e
Sonar fixes (Prefer using an optional chaining)
davidjamesstone Oct 16, 2025
6731643
Fix postcode tests
davidjamesstone Oct 16, 2025
ab0c861
Update unit tests
davidjamesstone Oct 16, 2025
0259165
Add assertion in postocde test
davidjamesstone Oct 16, 2025
87a48c3
Stash payload without crumb
davidjamesstone Oct 16, 2025
16a2b7f
Stash the payload from context not the request
davidjamesstone Oct 16, 2025
0061149
Remove unnecessary try-catch
davidjamesstone Oct 16, 2025
f268521
Update docs
davidjamesstone Oct 16, 2025
b46b912
Form group errors for UKAddress when using postcode lookup
davidjamesstone Oct 16, 2025
ca9ce60
Allow ordnanceSurveyApiKey config to be undefined
davidjamesstone Oct 16, 2025
54b3f7e
Change Boom type
davidjamesstone Oct 16, 2025
be7eca3
Rename variable
davidjamesstone Oct 16, 2025
f2dfbe8
Sonar fixes (use TypeError)
davidjamesstone Oct 16, 2025
34f0fce
Remove TODO
davidjamesstone Oct 16, 2025
aae6b68
Document address formatting
davidjamesstone Oct 16, 2025
72e1869
Update register unicorn address page
davidjamesstone Oct 16, 2025
9221aa2
Remove SASS warning
davidjamesstone Oct 17, 2025
36c4def
Reduce errors to a single validation message when using postcode lookup
davidjamesstone Oct 17, 2025
31745bb
Formatting
davidjamesstone Oct 17, 2025
8bf6d8c
Remove CustomerReferenceField from components.json
davidjamesstone Oct 17, 2025
c431558
Merge branch 'main' into feature/DF-511-postcode-lookup
davidjamesstone Oct 20, 2025
53f0261
Ensure full valid postcode query
davidjamesstone Oct 20, 2025
1fd72ec
Merge branch 'main' into feature/DF-511-postcode-lookup
davidjamesstone Oct 20, 2025
684e473
Merge branch 'feature/DF-511-postcode-lookup' of https://github.com/d…
davidjamesstone Oct 20, 2025
fe5cc30
Fix linting
davidjamesstone Oct 20, 2025
e868eac
Fix tests
davidjamesstone Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions jest.setup.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ process.env.UPLOADER_URL = 'https://test-uploader.cdp-int.defra.cloud'
process.env.UPLOADER_BUCKET_NAME = 'dummy-bucket'
process.env.GOOGLE_ANALYTICS_TRACKING_ID = 'G-123456789'
process.env.SUBMISSION_EMAIL_ADDRESS = 'dummy@defra.gov.uk'
process.env.ORDNANCE_SURVEY_API_KEY = 'dummy'
Loading
Loading