fix DF-529: errors inline on Location components#245
Merged
mokhld merged 11 commits intofix/DF-529-location-fixesfrom Nov 13, 2025
Merged
fix DF-529: errors inline on Location components#245mokhld merged 11 commits intofix/DF-529-location-fixesfrom
mokhld merged 11 commits intofix/DF-529-location-fixesfrom
Conversation
- Improved error message handling in `LocationFieldHelpers` by including `errorMessage` in the view model. - Modified HTML template to display error messages and adjust form group classes based on error presence.
mokhld
force-pushed
the
fix/no-jira-location-error-summaries
branch
from
fa336e7 to
239e231
Compare
… error handling and layout - Updated SCSS for error states in location input fields, ensuring consistent padding and margin. - Refactored HTML structure to utilize grid layout for better responsiveness and alignment of input items.
mokhld
force-pushed
the
fix/no-jira-location-error-summaries
branch
from
8ab6db0 to
ce6e46e
Compare
….com/defra/forms-engine-plugin into fix/no-jira-location-error-summaries
davidjamesstone
approved these changes
Nov 13, 2025
|
davidjamesstone
added a commit
that referenced
this pull request
Nov 13, 2025
* Fix location component error messages * Update OsGridRef precision * Remove NGFR 10 digit * Fix typo in latitude and longitude title and hint in unicorn breeder registration form * fix DF-529: errors inline on Location components (#245) * feat: errors inline on Location components - Improved error message handling in `LocationFieldHelpers` by including `errorMessage` in the view model. - Modified HTML template to display error messages and adjust form group classes based on error presence. * lint: fixes * test: update tests * fix: remove unnecessary whitespace in location field template * style: Updated flex properties for better layout on desktop and mobile views. * style: refactor location input styles and HTML structure for improved error handling and layout - Updated SCSS for error states in location input fields, ensuring consistent padding and margin. - Refactored HTML structure to utilize grid layout for better responsiveness and alignment of input items. * style: add margin-top to location input grid row for improved spacing * style: remove unused location input styles * Remove two thirds wrapper * style: remove unused location input imports from references --------- Co-authored-by: David Stone <davidjamesstone@gmail.com> * Add short description to location components in the unicorn form --------- Co-authored-by: Mohammed Khalid <emailmokhld@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocationFieldHelpersby includingerrorMessagein the view model.Proposed change
Jira ticket:
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).