Conversation
- Fix accordion spacing with nested form groups - Render markdown in templates for proper link handling - Streamline required message validation
| content: none; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I assume this doesn't have an impact on other components?
There was a problem hiding this comment.
Not that I can find. This only targets nested form groups because regular form fields don't use nested form groups. This is specifically needed for the location field components because we're wrapping the text field inside another form group for the proper error styling. It's a strange one.
| return { | ||
| pattern, | ||
| patternErrorMessage: `Enter a valid National Grid field number for ${lowerFirst(this.label)} like NG 1234 5678` | ||
| patternErrorMessage: `Enter a valid National Grid field number for {{#title}} like NG 1234 5678`, |
There was a problem hiding this comment.
Are we stripping spaces or insisting on spaces? Or allowing with/without spaces?
There was a problem hiding this comment.
We haven't changed the spaces at all. It still supports both formats. It only changes the error message template syntax for consistency.
jbarnsley10
left a comment
jbarnsley10
left a comment
There was a problem hiding this comment.
This looks great. A few questions (but probably no changes required). Approving in principal of you getting the tests working
|
2 participants
Proposed change
Jira ticket:
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).