Feat/df 702 - dont log for summary page with missing title#276
Feat/df 702 - dont log for summary page with missing title#276jbarnsley10 merged 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
Is this something we even need to log? A component must have a title anyway, right?
There was a problem hiding this comment.
The Summary pages can have a page title of empty so that they use the default 'Check your answers before sending your form'. Other pages can have an empty title (where it defaults to use the first question on the page).
So it does happen.
The question is ... are we bothered enough to log it?
There was a problem hiding this comment.
Sry I approved this PR but missed this convo
There was a problem hiding this comment.
So @alexluckett are you happy for me to remove the logging altogether (lines 418 - 424)?
There was a problem hiding this comment.
Sry I approved this PR but missed this convo
np, I always approve even if someone else isn't happy and leave it up to the other reviewer to block the PR.
There was a problem hiding this comment.
I think we can remove it, yeah @jbarnsley10 . Feel free. Debug if we're concerned as that won't show in prod, but it can be removed altogether.
|



Proposed change
Don't log unnecessarily for Summary pages that have an empty title, since it gets defaulted anyway
Jira ticket: DF-702
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).