feature/DF-370: Update save and exit plugin options, routes and message publication#903
Merged
davidjamesstone merged 28 commits intomainfrom Sep 9, 2025
Merged
Conversation
davidjamesstone
changed the title
davidjamesstone
force-pushed
the
feature/DF-370-save-form-progress-4
branch
2 times, most recently
from
f806077 to
200e40e
Compare
davidjamesstone
force-pushed
the
feature/DF-370-save-form-progress-4
branch
from
200e40e to
8784477
Compare
* import FormStatus from '@defra/forms-engine-plugin/types' * Update save and exit routes * Reworked with differnet flow * Stash * Corrected types Uses constructFormUrl for paths * Fix package-lock.json * Remove unnecessary classes * Update the save and exit routes and models * Add route param validation * Fix route typo * Route tests - more to follow * Bump @defra/forms-engine-plugin to v3.0.0 * SonarCloud issues * Extra coverage --------- Co-authored-by: David Stone <davidjamesstone@gmail.com>
alexluckett
reviewed
Sep 8, 2025
alexluckett
reviewed
Sep 8, 2025
Contributor
|
I've resolved the Sonar security false-positive. It'll disappear on the next scan. Looks like you're missing a test to cover |
…com/DEFRA/forms-runner into feature/DF-370-save-form-progress-4
davidjamesstone
changed the title
Extra tests
Boilerplate includes attempts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/DF-370
Dependent on this forms-engine-plugin PR