fix(DF-922): add version fallback and remove unused versionNumber option#46
Closed
fix(DF-922): add version fallback and remove unused versionNumber option#46
Conversation
Add try-catch fallback to getFormDefinition so versioned endpoint failures fall back to the current definition instead of crashing. Remove unused versionNumber from FormModel constructor call.
manager.js now imports createLogger at module level, so tests that import manager.js need to mock the logger to avoid pino init errors.
Use nock to intercept the OIDC JWKS endpoint during tests instead of hitting the real Microsoft endpoint, matching the pattern used by forms-submission-api.
|
jbarnsley10
approved these changes
Apr 14, 2026
Contributor
|
Not required any more now we've fixed the root cause. This can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getFormDefinitionso versioned endpoint failures fall back to the current definition instead of crashing.versionNumberfromFormModelconstructor call.