Skip to content

TGC-1259: Add hoisting for API based config form, to match direct fil…#826

Merged
aaroncarroll82 merged 14 commits intomainfrom
bugfix/TGC-1259-hoist-config-on-api-yaml
Apr 29, 2026
Merged

TGC-1259: Add hoisting for API based config form, to match direct fil…#826
aaroncarroll82 merged 14 commits intomainfrom
bugfix/TGC-1259-hoist-config-on-api-yaml

Conversation

@aaroncarroll82
Copy link
Copy Markdown
Contributor

@aaroncarroll82 aaroncarroll82 commented Apr 24, 2026

  1. Hoist page config to metadata for form definitions loaded via API
  2. Use correct compose config so that config API is used to provide example-grant-with-auth definition
    a. Update yaml used in compose setup to come from broker + API to match latest definition
  3. Ensure version can be pulled from metadata in controllers not extending PageController in formsPlugin
  4. Expose formsService via server.methods to ensure places that need it can actually get to it

@aaroncarroll82 aaroncarroll82 requested a review from a team April 24, 2026 14:25
dcapilla
dcapilla previously approved these changes Apr 24, 2026
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
Comment thread src/server/confirmation/config-confirmation.js Outdated
Comment thread src/server/confirmation/config-confirmation.test.js Outdated
Comment thread src/server/common/helpers/form-verify-and-request-load.test.js Outdated
Comment thread src/server/dev-tools/handlers/clear-application-state.handler.js Outdated
Comment thread src/server/common/helpers/form-verify-and-request-load.js
@sonarqubecloud
Copy link
Copy Markdown

@aaroncarroll82 aaroncarroll82 merged commit eba8edf into main Apr 29, 2026
6 checks passed
@aaroncarroll82 aaroncarroll82 deleted the bugfix/TGC-1259-hoist-config-on-api-yaml branch April 29, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants