Refactor SFD update handling in check-details.controller.js#840
Merged
DavidBarker-EE merged 10 commits intomainfrom Apr 29, 2026
Merged
Refactor SFD update handling in check-details.controller.js#840DavidBarker-EE merged 10 commits intomainfrom
DavidBarker-EE merged 10 commits intomainfrom
Conversation
- Streamlined SFD update link logic and conditional redirects. - Refactored config handling for `detailsPage`. - Added `getSFDUpdateUrl` method for URL generation. - Updated tests to mock SFD-related config values.
- Renamed `config` to `detailsConfig` for improved clarity. - Updated associated method parameters and references consistently.
- Added logic to handle conditional redirects based on SFD configuration. - Implemented `getSFDUpdateUrl` method for generating SFD update URLs. - Enhanced test scenarios to cover SFD-enabled and SFD-disabled cases. - Incorporated tolerated failure paths in `fetchAndProcessData` tests.
- Added logic to handle conditional redirects based on SFD configuration. - Implemented `getSFDUpdateUrl` method for generating SFD update URLs. - Enhanced test scenarios to cover SFD-enabled and SFD-disabled cases. - Incorporated tolerated failure paths in `fetchAndProcessData` tests.
- Improved conditional redirect handling for missing SFD update URLs. - Updated debug logs with refined log codes. - Added new test cases for scenarios with missing SFD URLs.
|
swdpcomputing
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
detailsPage.getSFDUpdateUrlmethod for URL generation.