Address lookup is not populating premises field#2363
Open
Address lookup is not populating premises field#2363
Conversation
https://eaflood.atlassian.net/browse/IWTF-5100 This bug is not on production yet, but must be fixed before we can do a release. When we use the address lookup to find an address, we can select an address by its house number or premises, but this field is then not being saved to the permission. This means that when we try to create a transaction in DynamoDb before taking payment, the permission fails validation and the journey cannot be continued. We need to make sure the premises field is being set correctly, and test that the full journey works afterwards and the full address is being saved to the CRM. Unit tests should also be written to cover this.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/IWTF-5100
This bug is not on production yet, but must be fixed before we can do a release.
When we use the address lookup to find an address, we can select an address by its house number or premises, but this field is then not being saved to the permission. This means that when we try to create a transaction in DynamoDb before taking payment, the permission fails validation and the journey cannot be continued.
We need to make sure the premises field is being set correctly, and test that the full journey works afterwards and the full address is being saved to the CRM. Unit tests should also be written to cover this.