Skip to content

IWTF-5045 rcp cancellation not showing in websales #2385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lailien3 merged 14 commits into from
Apr 28, 2026
Merged

IWTF-5045 rcp cancellation not showing in websales #2385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
de14278
Make the existing Telesales cancellation journey available to the public
lailien3 Mar 26, 2026
23301fd
remove mock
lailien3 Mar 26, 2026
f24decc
turn off SHOW_CANCELLATION_JOURNEY
lailien3 Mar 26, 2026
89756e2
update readme
lailien3 Apr 21, 2026
5a50953
add new env var name
lailien3 Apr 23, 2026
42e7d29
Merge branch 'develop' into feature/iwtf-5045-make-rcp-cancellation-a…
lailien3 Apr 23, 2026
96a4d08
remove expect chunk
lailien3 Apr 24, 2026
0b5ac77
Update gafl_webapp.env.example
lailien3 Apr 27, 2026
cbb199e
Merge branch 'develop' into feature/iwtf-5045-make-rcp-cancellation-a…
lailien3 Apr 27, 2026
54e28b2
add rcp cancelltion to session manager
lailien3 Apr 27, 2026
7860757
prettier fixe
lailien3 Apr 27, 2026
e7bc64f
testing testing
lailien3 Apr 27, 2026
31dd6ab
revert caps
lailien3 Apr 28, 2026
0d006ed
Update gafl_webapp.env.example
lailien3 Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docker/env/gafl_webapp.env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,4 @@ ENABLE_ANALYTICS_OPT_IN_DEBUGGING=true
SHOW_CANCELLATION_JOURNEY=true

## Public Switch
// DEV & TEST envs set to true; TRAIN, PRE, PROD set to false
SHOW_CANCELLATION_JOURNEY_PUBLIC=true
19 changes: 14 additions & 5 deletions packages/gafl-webapp-service/src/session-cache/__tests__/session-manager.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,12 @@ describe('isStaticResource', () => {
})

describe('includesRegex', () => {
const regexArray = [/^\/buy\/renew\/identify$/, /^\/renew\/.*$/, /^\/renew-my-licence\/.*$/]
const regexArray = [
/^\/buy\/renew\/identify$/,
/^\/renew\/.*$/,
/^\/renew-my-licence\/.*$/,
/^\/buy\/cancel-recurring-payment\/identify$/
]
it.each([
'/buy/renew/identify',
'/renew/ABC123',
Expand All @@ -39,14 +44,18 @@ describe('includesRegex', () => {
'/renew-my-licence/ABC123',
'/renew-my-licence/123123',
'/renew-my-licence/ABCDEF',
'/renew-my-licence/anytext'
'/renew-my-licence/anytext',
'/buy/cancel-recurring-payment/identify'
])('returns true if one of the regexes is matched %s', async path => {
expect(includesRegex(path, regexArray)).toBeTruthy()
})

it.each(['/buy/renew', '/buy', '/rene', '/buy/order-complete'])('returns false if one of the regexes is not matched %s', async path => {
expect(includesRegex(path, regexArray)).toBeFalsy()
})
it.each(['/buy/renew', '/buy', '/rene', '/buy/order-complete', '/buy/cancel-recurring-payment/details'])(
'returns false if one of the regexes is not matched %s',
async path => {
expect(includesRegex(path, regexArray)).toBeFalsy()
}
)
})

describe('Use session cookie', () => {
Expand Down
3 changes: 2 additions & 1 deletion packages/gafl-webapp-service/src/session-cache/session-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,12 @@ const agreedHandlerProtectionExemptSet = [
NEW_PRICES.uri
]

// regex for /renew/{referenceNumber?}, /buy/renew/identify, /renew-my-licence/{referenceNumber?}, and static guidance pages
// regex for /renew/{referenceNumber?}, /buy/renew/identify, /renew-my-licence/{referenceNumber?}, /buy/cancel-recurring-payment/identify, and static guidance pages
const startProtectionExemptSet = [
/^\/renew\/.*$/,
/^\/buy\/renew\/identify$/,
/^\/renew-my-licence\/.*$/,
/^\/buy\/cancel-recurring-payment\/identify$/,
/^\/guidance\/cookies$/,
/^\/guidance\/accessibility-statement$/,
/^\/guidance\/privacy-policy$/,
Expand Down
Loading