Skip to content

Conversation

@TymurGubayev
Copy link
Contributor

@TymurGubayev TymurGubayev commented Feb 9, 2025

image

Implement the unit banners and mouse tooltips optionally showing unit stress/happiness, name, and current job; optionally as a "banner" following units, or as a mouse tooltip.

This is an evolution of the work in DFHack/scripts#1365, which will be reduced to just the config UI.

@TymurGubayev
Copy link
Contributor Author

one truly new thing here compared to the DFHack/scripts#1365 is ['tooltip-follow-blink-milliseconds']=2000, -- I'm not sure what reasonable default should be (0 = always show), I feel 2 seconds might be a bit too fast.

end
config.data[key] = value
config:write()
config[key] = value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this work with the table-valued settings?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't gotten to that yet, I was thinking of an optional 3rd argument to set_settings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spectate set tooltip-stress-levels 6 text XD is now valid command

Also:
* print settings in key order
* use string keys to simplify using json for persistence
* change default tooltip-follow-blink-milliseconds to 3000ms
Also, make it possible to set `tooltip-stress-levels`.
@TymurGubayev
Copy link
Contributor Author

I think (hope) this part is done now. Config UI is in scripts, and possible other features (tooltips/banners for workshops) I think can be delayed.

If the ``spectate.tooltip`` overlay is enabled, toggle whether to show the
tooltip.

``tooltip-follow-blink-milliseconds`` (default: 3000)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll have to get feedback on this in the beta. It might make sense to default to always on for graphics mode but default to a slow blink for ascii. Other tools that display things over the map do that, like the warm/damp overlay and the gui/quickfort preview shadow.

TymurGubayev and others added 3 commits February 17, 2025 20:51
Co-authored-by: Myk <myk.taylor@gmail.com>
Co-authored-by: Myk <myk.taylor@gmail.com>
@myk002 myk002 merged commit e817518 into DFHack:develop Feb 18, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants