-
Notifications
You must be signed in to change notification settings - Fork 492
spectate.lua: implement unit banners and mouse tooltips #5264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
one truly new thing here compared to the DFHack/scripts#1365 is |
plugins/lua/spectate.lua
Outdated
| end | ||
| config.data[key] = value | ||
| config:write() | ||
| config[key] = value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does this work with the table-valued settings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't gotten to that yet, I was thinking of an optional 3rd argument to set_settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spectate set tooltip-stress-levels 6 text XD is now valid command
Also: * print settings in key order * use string keys to simplify using json for persistence * change default tooltip-follow-blink-milliseconds to 3000ms
Also, make it possible to set `tooltip-stress-levels`.
|
I think (hope) this part is done now. Config UI is in scripts, and possible other features (tooltips/banners for workshops) I think can be delayed. |
| If the ``spectate.tooltip`` overlay is enabled, toggle whether to show the | ||
| tooltip. | ||
|
|
||
| ``tooltip-follow-blink-milliseconds`` (default: 3000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll have to get feedback on this in the beta. It might make sense to default to always on for graphics mode but default to a slow blink for ascii. Other tools that display things over the map do that, like the warm/damp overlay and the gui/quickfort preview shadow.
Co-authored-by: Myk <myk.taylor@gmail.com>
Co-authored-by: Myk <myk.taylor@gmail.com>
Implement the unit banners and mouse tooltips optionally showing unit stress/happiness, name, and current job; optionally as a "banner" following units, or as a mouse tooltip.
This is an evolution of the work in DFHack/scripts#1365, which will be reduced to just the config UI.