Skip to content

[DEV-4545] dfxApproval kyc bug #3074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yannick1712 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[DEV-4545] dfxApproval kyc bug #3074

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7821f2
[DEV-4545] dfxApproval kyc bug
Yannick1712 Jan 29, 2026
ab14e49
[DEV-4545] Refactoring
Yannick1712 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/subdomains/generic/kyc/services/kyc.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,8 +391,18 @@ export class KycService {
if (approvalStep?.isOnHold) {
await this.kycStepRepo.update(...approvalStep.manualReview());
} else if (!approvalStep) {
const newStep = await this.initiateStep(kycStep.userData, KycStepName.DFX_APPROVAL);
await this.kycStepRepo.update(...newStep.manualReview());
const newStep = await this.initiateStep(kycStep.userData, KycStepName.DFX_APPROVAL).catch((e) => {
if (e.message.includes('Cannot insert duplicate key'))
return this.kycStepRepo.findOneBy({
name: KycStepName.DFX_APPROVAL,
status: ReviewStatus.ON_HOLD,
userData: { id: kycStep.userData.id },
});

throw e;
});

if (newStep) await this.kycStepRepo.update(...newStep.manualReview());
}
}
}
Expand Down
Loading