Release: develop -> main #3080
Open
Release: develop -> main #3080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
TaprootFreak and
davidleomay
as code owners
* [DEV-4545] dfxApproval kyc bug * [DEV-4545] Refactoring
…idging (#3054) * feat(liquidity): add LayerZero bridge adapter for Ethereum->Citrea bridging Add support for bridging USDC, USDT, and WBTC from Ethereum to Citrea using LayerZero OFT (Omnichain Fungible Token) protocol. - Add LAYERZERO_BRIDGE to LiquidityManagementSystem enum - Create LayerZeroBridgeAdapter with deposit command - Add LayerZero OFT adapter ABI (quoteSend, send, approvalRequired) - Configure OFT adapter addresses for USDC, USDT, WBTC - Support token approval and fee quoting * fix(liquidity): improve LayerZero adapter robustness - Fix validateParams to handle undefined params - Fix quoteSend return value (returns tuple, not array) - Improve checkCompletion with better error handling and logging - Add output amount verification in completion check * style: fix prettier formatting * refactor(liquidity): align LayerZero adapter with codebase conventions - Export LayerZeroBridgeCommands enum (consistent with other adapters) - Use switch statement in validateParams (consistent with DfxDexAdapter) - Throw error for unknown commands (consistent with other adapters) * fix(liquidity): improve LayerZero adapter professionalism - Throw OrderFailedException for failed Ethereum TX (not just return false) - Add ETH balance check before bridge execution - Extract token approval into separate method with proper error handling - Re-throw OrderFailedException in checkCompletion (don't swallow it) - Add logging for approval confirmation - Add detailed error messages for insufficient funds * refactor(liquidity): align LayerZero adapter with existing bridge patterns - Remove unnecessary service storage (only store clients, like ArbitrumL2BridgeAdapter) - Align checkCompletion error handling with EvmL2BridgeAdapter (throw OrderFailedException) - Simplify validateParams to match EvmL2BridgeAdapter pattern (return true) * fix(liquidity): prevent double-wrapping OrderFailedException in approval * chore: refactoring/fixes --------- Co-authored-by: David May <david.leo.may@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist