feat: add userAddresses support for linked address selection #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create useAddressItems hook for consistent address handling across screens - Update buy.screen.tsx to support linked addresses (userAddresses) - Update sell.screen.tsx to support linked addresses (userAddresses) - Fix double div in swap.screen.tsx - Fix incorrect form rules in swap.screen.tsx (bankAccount/asset/currency -> sourceAsset/targetAsset) The hook generates address items that include: - All addresses from linked wallets (userAddresses) - Current session address - 'Switch address' option for wallet switching This enables cross-chain operations where users can receive funds on linked addresses (e.g., Lightning via Bitcoin wallet).
🤖 PR Review Bot❌ TypeScript: 460 errors
|
- Remove duplicated userSessions, userAddressItems, sourceBlockchains, targetBlockchains, addressItems logic from swap.screen.tsx - Use shared useAddressItems hook for consistent behavior across all screens - Hook now returns availableBlockchains for asset filtering - Remove unused userSessions from hook return value This eliminates ~60 lines of duplicated code and ensures consistent address/blockchain selection behavior across buy, sell, and swap screens.
Collaborator
Author
|
redy for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the closed PR #702 with a cleaner implementation that properly supports linked addresses (userAddresses).
Changes:
useAddressItemshook for consistent address handling across all screensbuy.screen.tsxto support linked addressessell.screen.tsxto support linked addressesswap.screen.tsxswap.screen.tsx(was validating non-existent fields)How it works:
The new
useAddressItemshook generates address items that include:This enables cross-chain operations where users can receive funds on linked addresses (e.g., Lightning via Bitcoin wallet).
Why this approach vs PR #702:
PR #702 tried to separate blockchain and address selection into two dropdowns, but:
This PR keeps the single dropdown pattern (which works well) but adds userAddresses support consistently across buy, sell, and swap screens.
Test plan