Add accounting page for bank balance sheets #922
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
🤖 PR Review Bot
|
- Add /accounting route with Admin/Compliance guard - Add bank balance sheet T-account display (Soll/Haben) - Auto-select first bank on page load - Show opening balance, income, expenses, closing balance - Validate against defined closing balance (green/red indicator) - Add URL params for year and bank preselection - Add Playwright E2E tests for balance sheet functionality
TaprootFreak
force-pushed
the
feature/accounting-page
branch
from
fd67166 to
98b5f81
Compare
Replace all hardcoded dev.api.dfx.swiss and api.dfx.swiss URLs in test files with process.env.REACT_APP_API_URL to enable local testing against localhost API.
- Add 29 Playwright tests covering Summary and Detailed views - Test multiple banks (Raiffeisen, Maerki, Yapeal, Olkypay) and years (2024, 2025) - Implement proper authentication flow using redirect URL parameter - Add view switching tests (Summary <-> Detailed) - Add dropdown filter tests (Year, Bank, Type) - Add UI structure verification tests - Add validation message tests - Include screenshot baselines for visual regression testing - Fix waitForDetailedView to handle React state sync timing
| } | ||
|
|
||
| // Helper: Wait for app to be fully loaded | ||
| async function waitForAppLoaded(page: Page): Promise<void> { |
| const yearOptions = getYearOptions(); | ||
|
|
||
| // Get selected bank | ||
| const selectedBank = useMemo(() => banks.find((b) => b.iban === selectedBankIban), [banks, selectedBankIban]); |
- Increase viewport from 1280x720 to 1400x1200 for better visibility - Add scroll-to-bottom before screenshot to ensure full render - Regenerate all 35 accounting test baselines
| await takeCleanScreenshot(page, 'compare-01-maerki-2025-summary.png'); | ||
|
|
||
| // Get summary values | ||
| const summaryIncome = await page.locator('[data-testid="total-income"]').textContent(); |
|
|
||
| // Get summary values | ||
| const summaryIncome = await page.locator('[data-testid="total-income"]').textContent(); | ||
| const summaryExpenses = await page.locator('[data-testid="total-expenses"]').textContent(); |
| // Get summary values | ||
| const summaryIncome = await page.locator('[data-testid="total-income"]').textContent(); | ||
| const summaryExpenses = await page.locator('[data-testid="total-expenses"]').textContent(); | ||
| const summaryBalance = await page.locator('[data-testid="closing-balance"]').textContent(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/accountingroute with Admin/Compliance access guard?year=2025&bank=CH34...)Dependencies
Test plan
npx playwright test accounting-balances