Skip to content

feat(buy): hide Personal IBAN promo for EUR #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TaprootFreak merged 1 commit into from
Jan 20, 2026
Merged

feat(buy): hide Personal IBAN promo for EUR #927

TaprootFreak merged 1 commit into from
Jan 20, 2026

Conversation

@TaprootFreak
Copy link
Collaborator

@TaprootFreak TaprootFreak commented Jan 20, 2026

Summary

  • EUR now exclusively uses VIBAN (handled by API)
  • Personal IBAN promotion text only shown for non-EUR currencies

Changes

  • buy.screen.tsx: Added selectedCurrency?.name !== 'EUR' condition to Personal IBAN promo block

Dependencies

  • Requires: DFXswiss/api#... (EUR VIBAN mandatory)

Test plan

  • Test EUR buy → Personal IBAN promo should NOT be shown
  • Test CHF/GBP buy → Personal IBAN promo should still be shown

@TaprootFreak
feat(buy): hide Personal IBAN promo for EUR
2f52f2b 
- EUR now exclusively uses VIBAN (handled by API)
- Personal IBAN promotion text only shown for non-EUR currencies
@TaprootFreak TaprootFreak marked this pull request as ready for review January 20, 2026 20:23
@TaprootFreak TaprootFreak merged commit 240d83e into develop Jan 20, 2026
6 checks passed
@TaprootFreak TaprootFreak deleted the feature/eur-viban-mandatory branch January 20, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidleomay davidleomay Awaiting requested review from davidleomay davidleomay is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TaprootFreak