Skip to content

Conversation

@TaprootFreak
Copy link
Collaborator

Summary

  • Change invoice button to use tx.uid instead of tx.id
  • Remove hidden condition - button is now always visible
  • Update isInvoiceLoading state type from number to string

Why

Pending transactions (e.g., "Warten auf Zahlung") don't have a numeric id, only a uid. This change enables invoice download for all transactions.

Dependencies

This PR requires the following PRs to be merged first:

  1. API: Allow invoice generation for pending transactions via uid api#3029 - Backend support for uid in invoice endpoint
  2. Packages: Support uid parameter for getTransactionInvoice packages#124 - Type update for getTransactionInvoice

Temporary workaround

Contains a type cast (tx.uid as unknown as number) that should be removed after @dfx.swiss/react package is updated.

Test plan

  • Lint passes
  • Build passes
  • After dependencies merged: verify invoice download works for pending transactions

- Change invoice button to use tx.uid instead of tx.id
- Remove hidden condition (button always visible now)
- Update isInvoiceLoading state type to string

This enables invoice download for pending transactions that don't
have a numeric id yet.

Note: Requires @dfx.swiss/react package update (DFXswiss/packages#124)
@github-actions
Copy link

🤖 PR Review Bot

ℹ️ New TODOs/FIXMEs (1)

+                                // TODO: remove cast after @dfx.swiss/react update

This is an automated review. Please address the issues above.

@TaprootFreak TaprootFreak marked this pull request as ready for review January 22, 2026 16:26
@TaprootFreak TaprootFreak merged commit b945a81 into develop Jan 22, 2026
6 checks passed
@TaprootFreak TaprootFreak deleted the feat/invoice-use-uid branch January 22, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants