Skip to content

Php 8.1 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MPolleke wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Php 8.1 #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a73c64b
Support castling move with NAG in FenParser.
MPolleke Feb 16, 2021
d782df9
Fix silly mistake, don't know how it got there :)
MPolleke Feb 16, 2021
7757e97
Fix compatibility with PHP 8.1.
MPolleke May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions FenParser0x88.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1259,10 +1259,10 @@ function getFromAndToByNotation($notation)
case 0x03:
case 0x0B:

if ($notation === 'O-O') {
if (substr($notation, 0, 3) === 'O-O' && substr($notation, 0, 5) !== 'O-O-O') {
$foundPieces[] = ($offset + 4);
$ret['to'] = $offset + 6;
} else if ($notation === 'O-O-O') {
} else if (substr($notation, 0, 5) === 'O-O-O') {
$foundPieces[] = ($offset + 4);
$ret['to'] = $offset + 2;
} else {
Expand Down Expand Up @@ -1411,7 +1411,7 @@ function getToSquareByNotation($notation)

function getPieceTypeByNotation($notation, $color = null)
{
if ($notation === 'O-O-O' || $notation === 'O-O') {
if (substr($notation, 0, 5) === 'O-O-O' || substr($notation, 0, 3) === 'O-O') {
$pieceType = 'K';
} else {
$token = substr($notation, 0, 1);
Expand Down Expand Up @@ -1812,4 +1812,5 @@ private function getNewFen()

class FenParser0x88Exception extends Exception{

}
}

3 changes: 2 additions & 1 deletion PgnGameParser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
class PgnGameParser{

private $pgnGame;
private $moveBuilder;
private $defaultFen = 'rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w KQkq - 0 1';

private $gameData = array();
Expand Down Expand Up @@ -140,4 +141,4 @@ private function getMoveString() {
$gameData = preg_replace("/(\s+)/", " ", $gameData);
return trim($gameData);
}
}
}