Improve portability and fix minor bugs#3
Open
CapriciousRebel wants to merge 1 commit intoDJRHails:mainfrom
Open
Improve portability and fix minor bugs#3CapriciousRebel wants to merge 1 commit intoDJRHails:mainfrom
CapriciousRebel wants to merge 1 commit intoDJRHails:mainfrom
Conversation
- Remove hardcoded user email/name from gitconfig for portability - Fix perl regex in GPG key extraction (use $& to print match) - Make cargo env loading conditional to prevent errors when not installed - Simplify link.sh extract_and_link function and fix variable quoting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Author
|
Hi @DJRHails, this project looks super cool! I have added a few changes and minor fixes when trying to install it on my machine. Would aprreciate if you take a look at the PR 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
print $&instead ofprint)link.shextract_and_link function and fix variable quoting (On macOs we have bash 3.2 installed by default, associative arrays are not supported on bash 4 and under)🤖 Generated with Claude Code