to prevent replay attacks, check that this btcTxId hasnt been called … #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…before for this function; can move sig uniqueness checks to local function
scolear
requested changes
May 28, 2025
scolear
reviewed
May 28, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds additional tests to prevent replay attacks by ensuring that each btcTxId is only processed once and moves signature uniqueness checks into a local function.
- Introduces new test suites to check for nonce manipulation and replay attack scenarios.
- Updates the multisig validation logic in the Solidity contract by incorporating new processed transaction mappings and refining error handling.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/DLCManager.test.js | Added tests for nonce-manipulation and replay attack prevention; adjusted test parameters. |
| contracts/DLCManager.sol | Modified multisig validation logic, added new transaction status mappings, and updated error messages. |
Comments suppressed due to low confidence (1)
contracts/DLCManager.sol:288
- [nitpick] Consider renaming the first parameter in the TransactionAlreadyProcessed error to better reflect that it is a prefixed message hash rather than a transaction ID.
revert TransactionAlreadyProcessed(prefixedMessageHash, functionString);
test/DLCManager.test.js
Outdated
| expect(event.args.btcTxId).to.equal(btcTxId); | ||
| }); | ||
|
|
||
| it('Revert on attemped replay attacks when attacker trying to reuse sigs on same function and same btcTxId', async () => { |
There was a problem hiding this comment.
There is a typo in the test description ('attemped' should be 'attempted').
Suggested change
| it('Revert on attemped replay attacks when attacker trying to reuse sigs on same function and same btcTxId', async () => { | |
| it('Revert on attempted replay attacks when attacker trying to reuse sigs on same function and same btcTxId', async () => { |
Contributor
Author
There was a problem hiding this comment.
sounds good thanks CP!
scolear
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…before for this function; can move sig uniqueness checks to local function