Skip to content

Bugfix: Remove unallowed operations from hash strong type #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sandro-elsweijer wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −6
Open

Bugfix: Remove unallowed operations from hash strong type #2262

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6c1ef1
remove not allowed operations from geometry hash
sandro-elsweijer Apr 1, 2026
3860f63
fix typo
sandro-elsweijer Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/t8_geometry/t8_geometry_hash.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
*/

/** \file t8_geometry_hash.hxx
* Defines data types and functions for handling hash values of
* Defines data types and functions for handling hash values of
* geometries.
*/

Expand All @@ -40,17 +40,16 @@ struct t8_geometry_hash_tag
T8_EXTERN_C_BEGIN ();

/** Data type used for storing hash values of geometries. */
using t8_geometry_hash = T8Type<size_t, t8_geometry_hash_tag, Addable, Subtractable, AddAssignable, Multipliable,
Dividable, EqualityComparable, Hashable>;
using t8_geometry_hash = T8Type<size_t, t8_geometry_hash_tag, EqualityComparable, Hashable>;

/** Constant that we use for hashes of non-existing geometries. */
static const t8_geometry_hash t8_geometry_empty_hash (std::hash<std::string> {}(""));

/**
* Compute the hash value of a geometry's name.
*
*
* \param [in] name The name of a geometry.
* \return The hash value of \a name.
* \return The hash value of \a name.
* \note \a name being empty here is explicitly allowed and used as hash values for non-existing geometries.
*/
inline t8_geometry_hash
Expand All @@ -63,7 +62,7 @@ t8_geometry_compute_hash (const std::string &name)
/**
* Query whether a given hash value corresponds to an empty string and hence
* a non-existing geometry.
*
*
* \param [in] hash A hash value of a geometry.
* \return true If \a hash corresponds to a non-existing geometry,i.e. if \a hash == \a t8_geometry_empty_hash.
* \return false If \a hash corresponds to an existing geometry.
Expand Down
Loading