Allow either platform of emulator to be used as the source category#3
Open
DDH69 wants to merge 2 commits intoDMDTools:mainfrom
Open
Allow either platform of emulator to be used as the source category#3DDH69 wants to merge 2 commits intoDMDTools:mainfrom
DDH69 wants to merge 2 commits intoDMDTools:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last logic fix plus moving to use of the emulator as the category for the MENU_ROM=category,game has created difficulty for people using an emulator like Retroarch where many platforms use one emulator. To address this, rather than lose any functionality of the emulator choice, I've made the source category selectable between the Emulator and Platform in a configuration file DOFConnect.json that resides in the DLL folder. Now people can select the best configuration for them.
DOFConnect sends and information message to DOFLinx at startup showing the version (hard coded) of the DLL and the source category choice.