Skip to content

s3 to private #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sindhute wants to merge 5 commits into
base: main
Choose a base branch
from
Open

s3 to private #33

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d3d52e2
s3 to private
sindhute Jun 16, 2021
6c8b66a
Update cloud-formation-stack-status.yaml
sindhute Jun 17, 2021
18e21cd
Update cloud-formation-stack-status.yaml
sindhute Jun 17, 2021
a637eaf
Update myStaticWebsite.ts
sindhute Jun 17, 2021
161e847
restrict s3 public read
sindhute Jun 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion authenticated-cloud-docs/deployment/src/lib/s3/myStaticWebsite.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export class MyStaticWebsite extends Construct {
bucketName: `${siteDomain}-website`,
websiteIndexDocument: 'index.html',
websiteErrorDocument: 'error.html',
publicReadAccess: true,
publicReadAccess: falsepublic read a,

// The default removal policy is RETAIN, which means that cdk destroy will not attempt to delete
// the new bucket, and it will remain in your account until manually deleted. By setting the policy to
Expand Down