Open
Conversation
laizy
reviewed
Jul 10, 2017
|
|
||
| findflag := false | ||
| for k := 0; k < len(stateUpdater); k++ { | ||
| log.Trace(fmt.Sprintf("StateUpdate updaterPublickey %d: %x %x", k, stateUpdater[k].X, stateUpdater[k].Y)) |
Contributor
There was a problem hiding this comment.
use Tracef, Debugf, Warnf... method instead. see #332 for more details.
| // stateKey | ||
| statePrefix := []byte{byte(ST_STATES)} | ||
| stateKey := append(statePrefix, namespace...) | ||
| stateKey = append(stateKey, key...) |
Contributor
There was a problem hiding this comment.
this desgin may have problem since we can not figure out namespace and key from the stateKey.
case: namespace: dna, key: node3, and namespace:dnanode, key:3 will share the same underlying data。
recommendation: Use len(namespace) + namespace + key schema to construct the stateKey
Contributor
|
approve |
dreamfly281
requested changes
Jul 11, 2017
Collaborator
dreamfly281
left a comment
dreamfly281
left a comment
There was a problem hiding this comment.
Suggest verify in user specify branch before official be merged into main branch
Contributor
Author
|
this payload already verified in user case. |
support store a value use Namespace and key as index. Signed-off-by: zhengq1 <ljqlyy@gmail.com> (cherry picked from commit 5223bd3) Signed-off-by: zhengq1 <ljqlyy@gmail.com>
Honglei-Cong
pushed a commit
to Honglei-Cong/DNA
that referenced
this pull request
Nov 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support store a value use Namespace and key as index.
Signed-off-by: zhengq1 ljqlyy@gmail.com