Conversation
…n existing samples When --storage-account is provided, existing samples that match the provided sample IDs now have their storage_account_id updated. Previously, existing samples were carried forward unchanged, causing storage_account_id=null in the DB and breaking JSONB containment checks in the orchestration existing-run detection. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dnastack workbench runs samples addto updatestorage_account_idon existing samples when--storage-accountis providedstorage_account_id=nullin the DBContext
When re-adding samples with
--storage-account, the CLI skipped existing samples entirely. This causedstorage_account_id=nullin the DB, which broke JSONB containment checks in EWES orchestration existing-run detection.Related EWES fix: [CU-86b8p5pc7]
Test plan
test_add_existing_sample_updates_storage_account— verifies existing samples getstorage_account_idupdatedtest_add_existing_sample_preserves_storage_account_when_not_provided— guard test, existing behavior preserved🤖 Generated with Claude Code