This repository was archived by the owner on Feb 4, 2026. It is now read-only.
Initial support for SVCB/HTTPS (unfinished).#80
Draft
gjherbiet wants to merge 1 commit intoDNS-OARC:mainfrom
Draft
Initial support for SVCB/HTTPS (unfinished).#80gjherbiet wants to merge 1 commit intoDNS-OARC:mainfrom
gjherbiet wants to merge 1 commit intoDNS-OARC:mainfrom
Conversation
Only "port" SVC parameter is supported.
tobez
reviewed
Jun 30, 2025
| p = extract_integer(&s, "priority", NULL); | ||
| if (p < 0) | ||
| return NULL; | ||
| if (p > 65536) |
Contributor
There was a problem hiding this comment.
Either p > 65535 or p >= 65536 would be more correct here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only "port" SVC parameter is supported.