Skip to content

Call updateMonitoringMetrics in ApplyLoggingPlugins #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Call updateMonitoringMetrics in ApplyLoggingPlugins #2993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dnscrypt-proxy/plugins.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ type PluginsState struct {
synthResponse *dns.Msg
questionMsg *dns.Msg
xTransport *XTransport
proxy *Proxy
sessionData map[string]interface{}
action PluginsAction
timeout time.Duration
Expand Down Expand Up @@ -269,6 +270,7 @@ func NewPluginsState(
maxUnencryptedUDPSafePayloadSize: MaxDNSUDPSafePacketSize,
sessionData: make(map[string]interface{}),
xTransport: proxy.xTransport,
proxy: proxy,
}
}

Expand Down Expand Up @@ -403,5 +405,7 @@ func (pluginsState *PluginsState) ApplyLoggingPlugins(pluginsGlobals *PluginsGlo
return err
}
}
// Update monitoring metrics
updateMonitoringMetrics(pluginsState.proxy, pluginsState)
return nil
}
3 changes: 0 additions & 3 deletions dnscrypt-proxy/proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,9 +818,6 @@ func (proxy *Proxy) processIncomingQuery(
// Apply logging plugins
pluginsState.ApplyLoggingPlugins(&proxy.pluginsGlobals)

// Update monitoring metrics
updateMonitoringMetrics(proxy, &pluginsState)

return response
}

Expand Down