PVL Core by amystamile-usgs · Pull Request #5717 · DOI-USGS/ISIS3

amystamile-usgs · 2025-01-29T16:55:25Z

Description

Related Issue

How Has This Been Validated?

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Documentation change (update to the documentation; no code change)
Breaking change (fix or feature that would cause existing functionality to change)
Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

I have read and agree to abide by the Code of Conduct
I have read the CONTRIBUTING document.
My change requires a change to the documentation and I have updated the documentation accordingly.
I have added tests to cover my changes.
I have added myself to the .zenodo.json document.
I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

github-actions · 2025-01-29T16:56:16Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-01-31T15:18:38Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-01-31T15:31:03Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-02-03T20:04:45Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-02-04T15:17:08Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

amystamile-usgs · 2025-02-04T15:17:20Z

@Kelvinrr This should be ready for a review. I guess there is still the question of whether or not these changes are API breaking.

github-actions · 2025-02-05T17:19:27Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-02-06T15:39:42Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-04-10T15:23:44Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

amystamile-usgs · 2025-04-10T17:50:54Z

Rebased and no new tests failing outside of the dev test failures.

github-actions · 2025-09-03T21:29:15Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-09-04T18:50:48Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-09-05T18:07:55Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-09-09T17:44:11Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-09-09T21:11:38Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

* Fixed pvl core test config * Changed cmake_source to project_source for submodule

…ase-folding file system

…the build and install

github-actions · 2026-02-17T21:36:06Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2026-02-18T00:08:40Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2026-02-18T13:50:27Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2026-02-18T19:51:27Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

acpaquette

A couple small things to fix

acpaquette · 2026-02-20T21:47:28Z

isis/src/core/tests/ConstantsTests.cpp

@@ -0,0 +1,29 @@
+#include "Constants.h"


Did this file not get moved from isis/tests/ConstantsTest.cpp

acpaquette · 2026-02-20T21:51:22Z

isis/Makefile

-#ISISLIBVERSION       := $(shell echo $(ISISMAJOR).$(ISISMINOR).$(ISISMINORMINOR) | sed 's/[a-z].*$$//')
-#ISISLOCALVERSION     := $(shell head -n 3 $(ISISROOT)/version | tail -n 1 | sed 's/\#.*//' | sed 's/ *$$//')
-#ISISRELEASE          := REL_0_0
+# CMAKE generated file: DO NOT EDIT!


It's weird that this didn't cause an issue. Can we try reverting this file and see if the tests pass?

A bunch of tests are now failing after I reverted this Makefile

github-actions · 2026-02-20T22:08:28Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5717".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

amystamile-usgs requested a review from Kelvinrr February 4, 2025 15:17

amystamile-usgs force-pushed the new_pvl_core branch from 3e0c293 to aa1c64e Compare April 10, 2025 15:22

acpaquette force-pushed the new_pvl_core branch from aa1c64e to aefbe64 Compare September 3, 2025 21:28

acpaquette force-pushed the new_pvl_core branch from 7b81765 to 15d3a81 Compare September 5, 2025 18:07

AustinSanders and others added 11 commits February 17, 2026 14:25

Added history comment.

a2a7d4c

Initial move to core

e00845a

Removed Pvl cmakelists

363cf00

Removed more cmakelists.txt

fd2e0b0

Add subdirectory

73df83b

Fully modularized core

873a118

Fully modularized core

fbd5de7

replaced PvlEditDialog that was accidentally removed in prev commit

07f897a

Initial constants unit gtest

0cc8fc5

Fixed pvl core test config (#4349)

7112756

* Fixed pvl core test config * Changed cmake_source to project_source for submodule

Fixed pvl core test config

9f32585

acpaquette and others added 18 commits February 17, 2026 14:29

Added mesalib as a build and run dependency

9ba9ae4

Changed all Endian.h to IEndian.h to prevent include shadowing in a c…

3b8d944

…ase-folding file system

Fixed python find for python 3.9

6afc14a

Fix python find for 3.11

8561dd9

Changed mention of isisio to isiscore

1ae7dbb

Forgot to add name changed file

c64ca75

Add install command for python bindings

3fbbb64

rebase fixes and fixed PvlKeywordTest

dffd271

more rebase fixes

7213873

Updated core_recipe

0c98704

Fix latest release version

70a2468

conda-forge updates

60011d3

more conda-forge updates

c3d3b88

working conda-forge changes

e526aa7

Updated core preference files to match the base preference files

a106751

Updated Blob tests and changed how Isis/TestPreferences are added to …

f644023

…the build and install

Removed old blob tests

3e0cd1a

Removed blob unitTest in CmakeLists.txt

e7ba576

amystamile-usgs force-pushed the new_pvl_core branch from cbd926e to e7ba576 Compare February 17, 2026 21:35

fixes after rebase

6f2f7a4

fix IString test

2a2f1fd

amystamile-usgs added 2 commits February 18, 2026 08:15

Update meta.yaml, etc.

3aad7fe

various fixes and changelog

12c22f0

acpaquette reviewed Feb 20, 2026

View reviewed changes

Address PR feedback

55df4b4

Comments

Conversation

amystamile-usgs commented Jan 29, 2025

Description

Related Issue

How Has This Been Validated?

Types of changes

Checklist:

Licensing

Uh oh!

github-actions bot commented Jan 29, 2025

Uh oh!

github-actions bot commented Jan 31, 2025

Uh oh!

github-actions bot commented Jan 31, 2025

Uh oh!

github-actions bot commented Feb 3, 2025

Uh oh!

github-actions bot commented Feb 4, 2025

Uh oh!

amystamile-usgs commented Feb 4, 2025

Uh oh!

github-actions bot commented Feb 5, 2025

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

github-actions bot commented Apr 10, 2025

Uh oh!

amystamile-usgs commented Apr 10, 2025

Uh oh!

github-actions bot commented Sep 3, 2025

Uh oh!

github-actions bot commented Sep 4, 2025

Uh oh!

github-actions bot commented Sep 5, 2025

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

acpaquette left a comment

Choose a reason for hiding this comment

Uh oh!

acpaquette Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

acpaquette Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

amystamile-usgs Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants