Working ISISDATA-less web spice by Kelvinrr · Pull Request #5841 · DOI-USGS/ISIS3

Kelvinrr · 2025-06-17T00:13:03Z

Description

A few fixes to make it so ISISDATA is no longer required to use web spiceinit as long as the spiceqlweb flag is true in ISISPreferences.

Related Issue

How Has This Been Validated?

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Documentation change (update to the documentation; no code change)
Breaking change (fix or feature that would cause existing functionality to change)
Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

I have read and agree to abide by the Code of Conduct
I have read the CONTRIBUTING document.
My change requires a change to the documentation and I have updated the documentation accordingly.
I have added tests to cover my changes.
I have added myself to the .zenodo.json document.
I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

github-actions · 2025-06-17T00:13:45Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5841".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-06-17T00:15:43Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5841".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

Kelvinrr · 2025-06-17T16:13:25Z

this requires a SpiceQL release

github-actions · 2025-06-24T14:41:59Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5841".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-06-24T15:40:50Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5841".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-06-24T16:18:51Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5841".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-07-02T16:27:17Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5841".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-07-09T13:53:41Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5841".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-07-09T13:54:52Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5841".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-07-09T14:13:55Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5841".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-07-09T16:07:13Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5841".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2025-07-11T21:22:59Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5841".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2026-01-08T15:06:35Z

Thank you for your contribution!

Unfortunately, this pull request hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this pull request will be automatically closed in 180 days.

If you want to participate in our support prioritization meetings or be notified when support sprints are happening, you can sign up the support sprint notification emails here.

Read more about our support processs here

github-actions · 2026-01-14T21:29:38Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5841".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2026-01-15T19:32:37Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5841".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2026-01-16T18:24:33Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5841".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2026-02-19T22:13:41Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5841".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

Kelvinrr · 2026-02-19T22:14:35Z

isis/src/base/apps/spiceinit/spiceinit.cpp

+    else if (Preference::Preferences().useWebSpice()) {
+      json props;
+      props["web"] = true;
+      props["attach_kernels"] = true;
+
+      json isd = ale::load(icube->fileName().toStdString(), props.dump(), "ale", false, false, true);
+      icube->attachSpiceFromIsd(isd);
+      Application::Log(icube->group("Kernels")); 
+
+    }


Main change, use Ale web if the SpiceQL flag is true in preferences.

Kelvinrr · 2026-02-19T22:15:04Z

isis/src/base/objs/Isis/Isis.h

+  }
+

+  SpiceQL::addAliasKey("Mars_Reconnaissance_Orbiter", "MRO");


Might need to add more into SpiceQL

Kelvinrr added 14 commits April 4, 2025 08:49

added --download-base

5a4d58c

added overwrite flag

4db36f3

merge conflicts

9e57898

merge conflicts

ec3af8b

udpated script

8222902

added auto as default

4e362a4

added :325

e11c33e

pi

ad82606

fixed some things

bd4ebad

fixed bug

ef75db1

syntax error

f98d0e4

Merge branch 'dev' of github.com:USGS-Astrogeology/ISIS3

94f59c3

removed some itime spice calls

448227f

added working web spoice

8813615

removed couts

0d5ebc4

bump spiceql to 1.2.0

9654246

fix lrowaccal

530d4ae

fix mical

0dfc112

Fix iTime UTC and dayOfYear functions

992fa2e

bump spiceql to 1.2.1

ad23206

Merge branch 'dev' into spice

a692b34

trigger build

1ed31e9

accommodating spiceql 1.2.1 changes

c5766f3

chkim-usgs mentioned this pull request Jul 11, 2025

Fix ctxcal No Camera #5823

Merged

12 tasks

acpaquette added 2 commits July 11, 2025 14:21

Add function in ISIS Preference class to read UseWebSpice option

160af6d

Updated all places that need to check if web spice is enabled

4e7df95

acpaquette mentioned this pull request Dec 31, 2025

updated for latest Spiceql #5924

Closed

12 tasks

github-actions bot added the inactive Issue that has been inactive for at least 6 months label Jan 8, 2026

Kelvinrr added 2 commits January 9, 2026 23:13

merge conflicts

3af3972

added isis.h changes

88933ee

removed verbose

31a1b3e

removed table check

3e7a1fa

Kelvinrr added 2 commits February 9, 2026 20:39

merge conflcits

19e62ae

updated to use ALE for spiceinit

1bad556

Kelvinrr removed the inactive Issue that has been inactive for at least 6 months label Feb 19, 2026

Kelvinrr commented Feb 19, 2026

View reviewed changes

Kelvinrr requested a review from acpaquette February 19, 2026 22:35

		}


		SpiceQL::addAliasKey("Mars_Reconnaissance_Orbiter", "MRO");

Comments

Conversation

Kelvinrr commented Jun 17, 2025

Description

Related Issue

How Has This Been Validated?

Types of changes

Checklist:

Licensing

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

github-actions bot commented Jun 17, 2025

Uh oh!

Kelvinrr commented Jun 17, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

github-actions bot commented Jul 2, 2025

Uh oh!

github-actions bot commented Jul 9, 2025

Uh oh!

github-actions bot commented Jul 9, 2025

Uh oh!

github-actions bot commented Jul 9, 2025

Uh oh!

github-actions bot commented Jul 9, 2025

Uh oh!

github-actions bot commented Jul 11, 2025

Uh oh!

github-actions bot commented Jan 8, 2026

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

github-actions bot commented Jan 16, 2026

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

Kelvinrr Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Kelvinrr Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants