Add gtest for equalizer nonOverlapRetryBoth#5958
Add gtest for equalizer nonOverlapRetryBoth#5958AstroKEW78 wants to merge 5 commits intoDOI-USGS:devfrom
Conversation
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5958". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5958". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
| #include "ProcessByLine.h" | ||
| #include "SpecialPixel.h" | ||
|
|
||
| using namespace Isis; |
There was a problem hiding this comment.
Remove this line. It's no longer needed.
| ui.GetFileName("TOLIST") : ""); | ||
| } | ||
| } | ||
| Isis::equalizer(ui); |
There was a problem hiding this comment.
I think you need to initialize ui. example:UserInterface &ui = Application::GetUserInterface();
isis/tests/EqualizerAppTests.cpp
Outdated
| QString prefArg() { | ||
| return "-preference=$ISISROOT/TestPreferences"; | ||
| } | ||
|
|
There was a problem hiding this comment.
Not needed. gtests already pulls TestPreferences.
isis/tests/EqualizerAppTests.cpp
Outdated
| const QString inputSrc = joinPath(base, "input"); | ||
| const QString truthSrc = joinPath(base, "truth"); |
There was a problem hiding this comment.
We no longer utilize the input and truth directories. We manually add input (cubes/lists) in to the data area (under tests) and do EXPECT_* calls to compare against what was once the truth data. Looks like equalizer does pvl comparison so do an EXPECT call for each PVL keyword.
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5958". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5958". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
|
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5958". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
2 participants
Description
This PR ports the legacy Makefile-based nonOverlapRetryBoth equalizer test to Google Test.
This PR intentionally adds only one test to establish a clear, reviewable pattern for converting the remaining equalizer tests.
Related Issue
N/A
How Has This Been Validated?
Built locally and executed with:
ctest -R Equalizer.NonOverlapRetryBoth -V
PVL comparison via pvldiff using legacy .DIFF tolerance files
Cube comparison via cubediff with explicit tolerances
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: