Merged
Conversation
DRMacIver
changed the title
Adds scripts/fix_function_imports.py, a libcst-based tool that automatically moves imports from inside functions to module level, respecting # noqa: no-import-in-function suppressions. Runs before ruff in `just format` so ruff can deduplicate and sort the hoisted imports. Also fixes the two existing violations in __main__.py and test_state.py, and updates monkeypatch targets in test_main.py to match the new import locations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on to #64 - I failed to notice a failed push and as a result merged an earlier version of the work.
Further, it turns out the build was already failing on main, so this PR also fixes those problems.