JSON Schema Validation#75
Conversation
natalialuzuriaga
left a comment
There was a problem hiding this comment.
Overall very solid work here especially with the docs 👏 👏 -- this is soooo important since validation will ensure data quality for our code.json files
| systems: z.array(z.string()), | ||
| subsetInHealthcare: z.array(z.string()), | ||
| userType: z.array(z.string()), | ||
| maturityModelTier: z.number(), |
There was a problem hiding this comment.
Question: Does using the .min() function ensure that the field is filled out (aka it is a required field)? I am trying to see when it should be used and for what fields
There was a problem hiding this comment.
whatever doesnt have the .optional() method attached to it is an optional field and can be nil but everything else is required can cannot be nil. the .min() method is there to make sure that the field is not empty @natalialuzuriaga
|
quick aside but this is working great. in the |
natalialuzuriaga
left a comment
There was a problem hiding this comment.
All LGTM! Amazing job 🙌
Yasss!!! Working as intended 🙌 |
Add Validation for code.json
Summary
This PR implements automatic validation for code.json files using Zod, ensuring that both auto-generated and manually edited code.json files are valid before being merged.
What Changed
New Features:
How It Works
Generation Mode
Validation Mode
Testing