Pastel Node filter optimisation, and NBT filtering fix #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as well as a private field to keep track of if any NBT or tag checking is occurring.
Fix for creating networks with nodes A, B, C, with network inheriting node A's UUID, disconnecting node A (retaining network UUID), and connecting node A to node D, leading to node A and D being connected to network with A's UUID despite no connections, leading to an incorrect network state. This means recreating a network with the same nodes may have a different colour.
Owner
|
Great improvement, I like it a lot, thanks! TODO: run some final tests |
DaFuqs
reviewed
Dec 16, 2025
|
|
||
| if (this.getNodeType().usesFilters()) { | ||
| FilterConfigurable.readFilterNbt(nbt, this.filterItems); | ||
| this.filterHashset.clear(); |
Owner
There was a problem hiding this comment.
check: do we need to reset nbtCheckingFilterItems here?
Contributor
Author
There was a problem hiding this comment.
oh good point, absolutely klsdgf
DaFuqs
added a commit
that referenced
this pull request
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructs an internal hashmap of filtered Items for Pastel Nodes, to be used when no NBT / tag selection is occurring, with an internal count of how many special-cased filtering items are in the filter, so as to only use the optimised version when no special-casing is required. Should improve filtering performance in most cases - the cost is setting and removing items from a filter that have NBT is slightly more expensive, but the expense is roughly equivalent to the filter being checked once for the node for transfer, so it should almost certainly be a performance increase.
Additionally, prevented Lore from being lowercased in NBT filter handling, as it prevented any matches, and fixed damage checks by checking the NBT as an int as well as a number.