Honor inventory-specific max stack sizes in InventoryHelper #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaFuqs
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of adding items to an existing stack of items in an inventory with a lower limit than the items that it contains, Spectrum would overstack the items by only honoring the item's own stack limit. This was properly checked for the path that filled empty slots.
Minor API/ABI-compatible refactor to InventoryHelper to pass around max slot count context where necessary and obtain it where it was not available before.
Tested with Yttr's Scalable Storage Drum. This likely needs porting to the 1.21 branch.
~ Una