fix(ci): verify step — elf → wrapper for Python entry point#1
Merged
Conversation
CI's Verify step failed with "Not an ELF binary: result/bin/.corecycler-wrapped". Corecycler is a Python app packaged via `makeWrapper`, so `.corecycler-wrapped` is a Python shebang script, not an ELF binary. The workflow (ci.yml) already has a "wrapper" check type for exactly this case — just needs `.github/update.json` to opt in.
Daaboulex
added a commit
that referenced
this pull request
Apr 22, 2026
CI's Verify step failed with "Not an ELF binary: result/bin/.corecycler-wrapped". Corecycler is a Python app packaged via `makeWrapper`, so `.corecycler-wrapped` is a Python shebang script, not an ELF binary. The workflow (ci.yml) already has a "wrapper" check type for exactly this case — just needs `.github/update.json` to opt in.
Daaboulex
added a commit
that referenced
this pull request
Apr 22, 2026
CI's Verify step failed with "Not an ELF binary: result/bin/.corecycler-wrapped". Corecycler is a Python app packaged via `makeWrapper`, so `.corecycler-wrapped` is a Python shebang script, not an ELF binary. The workflow (ci.yml) already has a "wrapper" check type for exactly this case — just needs `.github/update.json` to opt in.
Daaboulex
added a commit
that referenced
this pull request
Apr 22, 2026
CI's Verify step failed with "Not an ELF binary: result/bin/.corecycler-wrapped". Corecycler is a Python app packaged via `makeWrapper`, so `.corecycler-wrapped` is a Python shebang script, not an ELF binary. The workflow (ci.yml) already has a "wrapper" check type for exactly this case — just needs `.github/update.json` to opt in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI's Verify step fails with:
(Run: 24312056674)
Corecycler is a Python app packaged via Nix's `makeWrapper`. The binary at `result/bin/.corecycler-wrapped` is a Python shebang script, not an ELF binary.
Fix
The workflow (`.github/workflows/ci.yml`) already has a `"wrapper"` check type for exactly this case — it just verifies the wrapper exists and is executable, without `file | grep ELF`. Switch `.github/update.json` from `"check": "elf"` to `"check": "wrapper"`.
Test plan