CMake search path cleanup #1857
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These variables in the mingw cross toolchain files no longer mean anything since the line that sets CMAKE_FIND_ROOT_PATH was removed in 14a9eb7.
We were adding the external deps location to both CMAKE_FIND_ROOT_PATH and CMAKE_PREFIX_PATH. Only one is needed. CMAKE_PREFIX_PATH has the weird behavior that if CMAKE_FIND_ROOT_PATH and CMAKE_PREFIX_PATH are both set, each (root path) X (prefix path) pair is considered, and when one isn't a subpath of the other, the search directory that results is formed by concatenating the root path and the prefix path. The deps dir is always an absolute path and not something that we want to be concatenated in the middle, so avoid using CMAKE_PREFIX_PATH. This should make it possible to use CMAKE_FIND_ROOT_PATH in a toolchain file without getting issues from the concatenation behavior, if it turn out to be truly necessary for some toolchain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.