Homework all done by salexkon · Pull Request #20 · DafeCpp/spring_alogorithms

salexkon · 2025-06-21T20:37:34Z

All tasks done with tests

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 15 out of 16. Check the log or trigger a new build to see more.

github-actions · 2025-06-21T20:40:32Z

+std::vector<int> find_two_nums(int target, std::vector<int> arr) {
+  int left = 0;
+  int right = arr.size() - 1;
+  int sum = arr[right] + arr[left];


warning: Value stored to 'sum' during its initialization is never read [clang-analyzer-deadcode.DeadStores]

int sum = arr[right] + arr[left]; ^

Additional context

task_01/src/task_01.cpp:5: Value stored to 'sum' during its initialization is never read

int sum = arr[right] + arr[left]; ^

поправь это замечание от clang-tidy

и лучше поправить все замечания от clang-tidy

github-actions · 2025-06-21T20:40:32Z

+
+#include "buy_fish.hpp"
+
+int totalFishBought(const std::vector<int>& purchases) {


warning: function 'totalFishBought' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

int totalFishBought(const std::vector<int>& purchases) {

static int totalFishBought(const std::vector<int>& purchases) {

это не обязательно исправлять, но лучше исправить

для исправления можно просто обернуть все в безымянный namespace

namespace { int totalFishBought(const std::vector<int>& purchases) { ... } bool isValidSchedule(const std::vector<int>& purchases, int k) { ... } }

github-actions · 2025-06-21T20:40:32Z

+  return total;
+}
+
+bool isValidSchedule(const std::vector<int>& purchases, int k) {


warning: function 'isValidSchedule' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

bool isValidSchedule(const std::vector<int>& purchases, int k) {

static bool isValidSchedule(const std::vector<int>& purchases, int k) {

github-actions · 2025-06-21T20:40:32Z

+
+#include "QuickSort.hpp"
+
+bool isSorted(const std::vector<int>& arr) {


warning: function 'isSorted' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

bool isSorted(const std::vector<int>& arr) {

static bool isSorted(const std::vector<int>& arr) {

github-actions · 2025-06-21T20:40:33Z

+      for (const auto& entry : table[i]) {
+        std::cout << "(" << entry.first << ": " << entry.second << ") ";
+      }
+      std::cout << std::endl;


warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]

Suggested change

std::cout << std::endl;

std::cout << '\n';

github-actions · 2025-06-21T20:40:33Z

+
+  auto res = ht.find("apple");
+  ASSERT_TRUE(res.has_value());
+  EXPECT_EQ(res.value(), 10);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

EXPECT_EQ(res.value(), 10); ^

github-actions · 2025-06-21T20:40:33Z

+
+  res = ht.find("banana");
+  ASSERT_TRUE(res.has_value());
+  EXPECT_EQ(res.value(), 20);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

EXPECT_EQ(res.value(), 20); ^

github-actions · 2025-06-21T20:40:33Z

+
+  res = ht.find("orange");
+  ASSERT_TRUE(res.has_value());
+  EXPECT_EQ(res.value(), 30);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

EXPECT_EQ(res.value(), 30); ^

github-actions · 2025-06-21T20:40:33Z

+
+  auto res = ht.find("apple");
+  ASSERT_TRUE(res.has_value());
+  EXPECT_EQ(res.value(), 50);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

EXPECT_EQ(res.value(), 50); ^

github-actions · 2025-06-21T20:40:33Z

+
+  res = ht.find("banana");
+  ASSERT_TRUE(res.has_value());
+  EXPECT_EQ(res.value(), 20);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

EXPECT_EQ(res.value(), 20); ^

github-actions

clang-tidy made some suggestions

github-actions · 2025-06-22T08:43:04Z

+  for (int i = 0; i < 1000; ++i) {
+    auto val = ht.find("key" + std::to_string(i));
+    ASSERT_TRUE(val.has_value());
+    EXPECT_EQ(val.value(), i);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

EXPECT_EQ(val.value(), i); ^

LostPointer · 2025-06-22T20:14:29Z

+#pragma once
+#include <vector>
+
+std::vector<int> find_two_nums(int target, std::vector<int> arr);


FindTwoNums

передавай массив по конфстантной ссылке что бы не было копирования

LostPointer · 2025-06-22T20:21:11Z

 #include <vector>

+template <typename T>
 class Stack {


давай хотя бы еще метод Size добавим, а лучше и ещё IsEpty (можно и просто Empty)

LostPointer · 2025-06-22T20:22:33Z

+    return result;
+  }
+
+  T getmax() {


LostPointer · 2025-06-22T20:23:38Z

 private:
-  std::vector<int> data_;
+  std::vector<T> data_;
+  std::vector<T> data_mins;


data_mins_ для data_ добавили подчеркивание что бы обозначить что это private поле, а для data_mins не добавили, чем оно хуже)

LostPointer · 2025-06-22T20:24:27Z

добавь своих тестов, например с пустым стэком

LostPointer · 2025-06-22T20:24:50Z

@@ -1 +1,18 @@
 #include "topology_sort.hpp"
+
+std::vector<int> days_until_warmer(const std::vector<int>& temperatures) {


DaysUntilWarmer

LostPointer · 2025-06-22T20:26:55Z

переименуй файл плиз) название из прошлого семестра осталось) (алгоритмы 2 семетр)

LostPointer · 2025-06-22T20:27:48Z

добавь тестов на пустой массив

LostPointer · 2025-06-22T20:34:01Z

@@ -0,0 +1,26 @@
+#include "QuickSort.hpp"
+
+void quickSortwrap(std::vector<int>& arr, int low, int high) {


Функция quickSortwrap не предназначена для внешнего использования, поместить в анонимное пространство имён (и убрать из hpp)

LostPointer · 2025-06-22T20:36:13Z

+  int right = arr.size() - 1;
+
+  while (left <= right) {
+    int pivotIndex = left + rand() % (right - left + 1);


pivot_index по кодстайлу)

LostPointer · 2025-06-22T20:39:14Z

+
+#include <iostream>
+
+struct Node {


лучше сделать внутреннем классом AVLTree (в private). это часть реализации, ее лучше скрывать

LostPointer · 2025-06-22T20:48:39Z

+  Node(int k) : key(k), left(nullptr), right(nullptr), height(1) {}
+};
+
+class AVLTree {


выделение памяти через new есть, а деструктора нет, значит есть утечка памяти

LostPointer · 2025-06-22T20:50:35Z

+#include <vector>
+
+template <typename T>
+class HashTable {


давай добавим методы Size и IsEmpty

github-actions

clang-tidy made some suggestions

github-actions · 2025-06-22T21:46:28Z

+    Node* left{nullptr};
+    Node* right{nullptr};
+    int height;
+    Node(int k) : key(k), left(nullptr), right(nullptr), height(1) {}


warning: member initializer for 'left' is redundant [cppcoreguidelines-use-default-member-init]

Suggested change

Node(int k) : key(k), left(nullptr), right(nullptr), height(1) {}

Node(int k) : key(k), , right(nullptr), height(1) {}

github-actions · 2025-06-22T21:46:28Z

+    Node* left{nullptr};
+    Node* right{nullptr};
+    int height;
+    Node(int k) : key(k), left(nullptr), right(nullptr), height(1) {}


warning: member initializer for 'right' is redundant [cppcoreguidelines-use-default-member-init]

Suggested change

Node(int k) : key(k), left(nullptr), right(nullptr), height(1) {}

Node(int k) : key(k), left(nullptr), , height(1) {}

github-actions · 2025-06-22T21:46:28Z

+    Node* left{nullptr};
+    Node* right{nullptr};
+    int height;
+    Node(int k) : key(k), left(nullptr), right(nullptr), height(1) {}


warning: use default member initializer for 'height' [cppcoreguidelines-use-default-member-init]

Suggested change

Node(int k) : key(k), left(nullptr), right(nullptr), height(1) {}

int height{1};

Node(int k) : key(k), left(nullptr), right(nullptr), {}

github-actions · 2025-06-22T21:46:28Z

+
+  Node* root = nullptr;
+
+  int height(Node* n) { return n ? n->height : 0; }


warning: Use of memory after it is freed [clang-analyzer-cplusplus.NewDelete]

int height(Node* n) { return n ? n->height : 0; } ^

Additional context

task_07/src/test.cpp:63: Calling 'AVLTree::erase'

tree.erase(15); ^

task_07/src/AVLTree.hpp:144: Calling 'AVLTree::erase'

void erase(int key) { root = erase(root, key); } ^

task_07/src/AVLTree.hpp:97: 'node' is non-null

if (!node) return node; ^

task_07/src/AVLTree.hpp:97: Taking false branch

if (!node) return node; ^

task_07/src/AVLTree.hpp:99: Assuming 'key' is >= field 'key'

if (key < node->key) ^

task_07/src/AVLTree.hpp:99: Taking false branch

if (key < node->key) ^

task_07/src/AVLTree.hpp:101: Assuming 'key' is <= field 'key'

else if (key > node->key) ^

task_07/src/AVLTree.hpp:101: Taking false branch

else if (key > node->key) ^

task_07/src/AVLTree.hpp:104: Field 'left' is null

if (!node->left || !node->right) { ^

task_07/src/AVLTree.hpp:104: Left side of '||' is true

if (!node->left || !node->right) { ^

task_07/src/AVLTree.hpp:105: Field 'left' is null

Node* temp = node->left ? node->left : node->right; ^

task_07/src/AVLTree.hpp:105: '?' condition is false

Node* temp = node->left ? node->left : node->right; ^

task_07/src/AVLTree.hpp:106: 'temp' is non-null

if (!temp) { ^

task_07/src/AVLTree.hpp:106: Taking false branch

if (!temp) { ^

task_07/src/AVLTree.hpp:112: Calling '~Node'

delete temp; ^

task_07/src/AVLTree.hpp:13: Memory is released

delete left; ^

task_07/src/AVLTree.hpp:112: Returning from '~Node'

delete temp; ^

task_07/src/AVLTree.hpp:120: 'node' is non-null

if (!node) return node; ^

task_07/src/AVLTree.hpp:120: Taking false branch

if (!node) return node; ^

task_07/src/AVLTree.hpp:122: Calling 'AVLTree::balance'

return balance(node); ^

task_07/src/AVLTree.hpp:57: Calling 'AVLTree::updateHeight'

updateHeight(n); ^

task_07/src/AVLTree.hpp:27: Calling 'AVLTree::height'

n->height = 1 + std::max(height(n->left), height(n->right)); ^

task_07/src/AVLTree.hpp:20: 'n' is non-null

int height(Node* n) { return n ? n->height : 0; } ^

task_07/src/AVLTree.hpp:20: '?' condition is true

int height(Node* n) { return n ? n->height : 0; } ^

task_07/src/AVLTree.hpp:20: Use of memory after it is freed

int height(Node* n) { return n ? n->height : 0; } ^

github-actions · 2025-06-22T21:46:28Z

+  }
+
+  void updateHeight(Node* n) {
+    n->height = 1 + std::max(height(n->left), height(n->right));


warning: Use of memory after it is freed [clang-analyzer-cplusplus.NewDelete]

n->height = 1 + std::max(height(n->left), height(n->right)); ^

Additional context

task_07/src/AVLTree.hpp:144: Calling 'AVLTree::erase'

void erase(int key) { root = erase(root, key); } ^

task_07/src/AVLTree.hpp:97: Assuming 'node' is non-null

if (!node) return node; ^

task_07/src/AVLTree.hpp:97: Taking false branch

if (!node) return node; ^

task_07/src/AVLTree.hpp:99: Assuming 'key' is >= field 'key'

if (key < node->key) ^

task_07/src/AVLTree.hpp:99: Taking false branch

if (key < node->key) ^

task_07/src/AVLTree.hpp:101: Assuming 'key' is > field 'key'

else if (key > node->key) ^

task_07/src/AVLTree.hpp:101: Taking true branch

else if (key > node->key) ^

task_07/src/AVLTree.hpp:102: Calling 'AVLTree::erase'

node->right = erase(node->right, key); ^

task_07/src/AVLTree.hpp:97: Assuming 'node' is non-null

if (!node) return node; ^

task_07/src/AVLTree.hpp:97: Taking false branch

if (!node) return node; ^

task_07/src/AVLTree.hpp:99: Assuming 'key' is < field 'key'

if (key < node->key) ^

task_07/src/AVLTree.hpp:99: Taking true branch

if (key < node->key) ^

task_07/src/AVLTree.hpp:100: Calling 'AVLTree::erase'

node->left = erase(node->left, key); ^

task_07/src/AVLTree.hpp:97: Assuming 'node' is non-null

if (!node) return node; ^

task_07/src/AVLTree.hpp:97: Taking false branch

if (!node) return node; ^

task_07/src/AVLTree.hpp:99: Assuming 'key' is < field 'key'

if (key < node->key) ^

task_07/src/AVLTree.hpp:99: Taking true branch

if (key < node->key) ^

task_07/src/AVLTree.hpp:100: Calling 'AVLTree::erase'

node->left = erase(node->left, key); ^

task_07/src/AVLTree.hpp:97: Assuming 'node' is non-null

if (!node) return node; ^

task_07/src/AVLTree.hpp:97: Taking false branch

if (!node) return node; ^

task_07/src/AVLTree.hpp:99: Assuming 'key' is >= field 'key'

if (key < node->key) ^

task_07/src/AVLTree.hpp:99: Taking false branch

if (key < node->key) ^

task_07/src/AVLTree.hpp:101: Assuming 'key' is <= field 'key'

else if (key > node->key) ^

task_07/src/AVLTree.hpp:101: Taking false branch

else if (key > node->key) ^

task_07/src/AVLTree.hpp:104: Assuming field 'left' is null

if (!node->left || !node->right) { ^

task_07/src/AVLTree.hpp:104: Left side of '||' is true

if (!node->left || !node->right) { ^

task_07/src/AVLTree.hpp:105: Field 'left' is null

Node* temp = node->left ? node->left : node->right; ^

task_07/src/AVLTree.hpp:105: '?' condition is false

Node* temp = node->left ? node->left : node->right; ^

task_07/src/AVLTree.hpp:106: Assuming 'temp' is non-null

if (!temp) { ^

task_07/src/AVLTree.hpp:106: Taking false branch

if (!temp) { ^

task_07/src/AVLTree.hpp:112: Calling '~Node'

delete temp; ^

task_07/src/AVLTree.hpp:13: Memory is released

delete left; ^

task_07/src/AVLTree.hpp:112: Returning from '~Node'

delete temp; ^

task_07/src/AVLTree.hpp:120: 'node' is non-null

if (!node) return node; ^

task_07/src/AVLTree.hpp:120: Taking false branch

if (!node) return node; ^

task_07/src/AVLTree.hpp:122: Calling 'AVLTree::balance'

return balance(node); ^

task_07/src/AVLTree.hpp:57: Calling 'AVLTree::updateHeight'

updateHeight(n); ^

task_07/src/AVLTree.hpp:27: Use of memory after it is freed

n->height = 1 + std::max(height(n->left), height(n->right)); ^

github-actions · 2025-06-22T21:46:28Z

+
+class AVLTreeTest : public ::testing::Test {
+ protected:
+  AVLTree tree;


warning: member variable 'tree' has protected visibility [cppcoreguidelines-non-private-member-variables-in-classes]

AVLTree tree; ^

github-actions · 2025-06-22T21:46:29Z

+ private:
+  std::vector<std::list<std::pair<std::string, T>>> table;
+  int capacity;
+  int size;


warning: use default member initializer for 'size' [cppcoreguidelines-use-default-member-init]

Suggested change

int size;

int size{0};

task_08/src/HashTable.hpp:41:

- HashTable(int init_capacity = 8) : capacity(init_capacity), size(0) { + HashTable(int init_capacity = 8) : capacity(init_capacity), {

salexkon added 19 commits June 21, 2025 09:55

task_1_done_no_tests

d3d7d03

task_01 clang-format

7db5c52

task_03 done without test, clang-formatted

5c4d4d8

task_04 done no test, clang-formatted

9ddc619

task_05 done no test, clang-formatted

94dfe8d

task_06 done no test, clang-formatted

221fe94

task_07 done no tests, clang-formatted

5a5182f

task_08 done no test, clang-formatted

8345d8a

task_09 done no tests, clang-formatted

2211c73

task_01 tests

e76926e

task_03 tests

928a363

task_04 tests

51ed9cd

task_05 tests

363407e

task_06 tests

fa9d1a4

task_07 tests

ca4da35

task_08 tests

d587a5f

task_09 tests

248aa2c

task_08 template

90a2574

all clang-formatted

8b50a80

github-actions Bot reviewed Jun 21, 2025

View reviewed changes

task_02 modified

772e03e

github-actions Bot reviewed Jun 22, 2025

View reviewed changes