Open
Conversation
LostPointer
requested changes
Apr 10, 2026
| #include <utility> | ||
| #include <vector> | ||
|
|
||
| using namespace std; |
Contributor
There was a problem hiding this comment.
не приветствую использование using namespace std
|
|
||
| using namespace std; | ||
|
|
||
| pair<int, int> func(const vector<int>& arr, int Summa) { |
Contributor
There was a problem hiding this comment.
плохое название функции, непонятно что она делает( и второй параметр не по кодстайлу, параметры как и переменные с маленькой_буквы_с_подчеркиванием_если_несколько_слов, и транслит не нужно использовать, просто sum
| TEST(Task1Test, NegativeNumbers) { | ||
| vector<int> arr = {-5, -3, 0, 2, 4}; | ||
| int S = -1; | ||
| pair<int, int> result = func(arr, S); |
Contributor
There was a problem hiding this comment.
можно не исправлять, но если что-то не меняется то лучше сделать константой
|
|
||
| using namespace std; | ||
|
|
||
| TEST(TopologySort, Simple) { ASSERT_EQ(1, 1); } |
|
|
||
| using namespace std; | ||
|
|
||
| int func(int N, int K, const vector<int>& arr) { |
Contributor
There was a problem hiding this comment.
тут сложность O(N*K), можно просто за O(N)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.