Should fix "UTF-8 file with BOM causes DateTime.Parse to fail"#4
Open
nul800sebastiaan wants to merge 2 commits intoDanDiplo:masterfrom
nul800sebastiaan:BOM-fix2
Open
Should fix "UTF-8 file with BOM causes DateTime.Parse to fail"#4nul800sebastiaan wants to merge 2 commits intoDanDiplo:masterfrom nul800sebastiaan:BOM-fix2
nul800sebastiaan wants to merge 2 commits intoDanDiplo:masterfrom
nul800sebastiaan:BOM-fix2
Conversation
Contributor
Author
|
Would recommend to wait with merging until the reporter can verify if it works as I can't repro this locally. |
Owner
|
Thanks Seb! Like I said in the thread, I can't reproduce either. Wonder if there are some other "special" characters in place causing this? But I can't see reading as UTF-8 would do any harm, either. Lets see if the OP gets back... |
Contributor
Author
|
Updated and tested against an actual problematic file. Should be good now, just want Sandro to confirm. |
Owner
|
Excellent! Who knew reading a text file could be so complex? :) |
Contributor
Author
|
I know, right? Insane! ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: http://our.umbraco.org/projects/developer-tools/diplo-trace-log-viewer/diplo-trace-log-viewer/56620-UTF-8-file-with-BOM-causes-DateTimeParse-to-fail
Now fixed using this method: http://stackoverflow.com/a/4172005/5018