Applied rules:

 * DisallowedEmptyRuleFixerRector
 * RemoveUnusedNonEmptyArrayBeforeForeachRector

Author: DanProgs

firstLogin.php

@@ -199,7 +199,7 @@ function notifyGlobalAdmins(&$dbHandler, &$userObj)
         }
 
         // silence errors
-        if (! empty($dest)) {
+        if ($dest !== []) {
             $mail['to'] = implode(',', $dest); // email_api uses ',' as list separator
             $mail['subject'] = lang_get('new_account');
             $mail['body'] = lang_get('new_account') . "\n";

lib/api/rest/v1/tlRestApi.class.php

@@ -395,7 +395,7 @@ public function getProjectTestCases($idCard)
             $tcaseIDSet = array();
             $this->tprojectMgr->get_all_testcases_id($tproject[0]['id'],
                 $tcaseIDSet);
-            if (! empty($tcaseIDSet)) {
+            if ($tcaseIDSet !== []) {
                 $op['items'] = array();
                 foreach ($tcaseIDSet as $tcaseID) {
                     $item = $this->tcaseMgr->getLastVersionInfo($tcaseID);

lib/api/rest/v2/tlRestApi.class.php

@@ -514,7 +514,7 @@ public function getProjectTestCases($idCard)
             $this->tprojectMgr->get_all_testcases_id($tproject['id'],
                 $tcaseIDSet);
 
-            if (! empty($tcaseIDSet)) {
+            if ($tcaseIDSet !== []) {
                 $op['items'] = array();
                 foreach ($tcaseIDSet as $tcaseID) {
                     $item = $this->tcaseMgr->getLastVersionInfo($tcaseID);
@@ -1811,7 +1811,7 @@ public function addPlatformsToTestPlan($tplan_id)
                         $p2link[$plat_id] = $plat_id;
                     }
                 }
-                if (! empty($p2link)) {
+                if ($p2link !== []) {
                     $platMgr->linkToTestplan($p2link, $tplan_id);
                 }
             }

lib/api/rest/v3/RestApi.class.php

@@ -347,7 +347,7 @@ public function getProjectTestCases(Response $response, $idCard)
             $this->tprojectMgr->get_all_testcases_id($tproject['id'],
                 $tcaseIDSet);
 
-            if (! empty($tcaseIDSet)) {
+            if ($tcaseIDSet !== []) {
                 $op['items'] = array();
                 foreach ($tcaseIDSet as $tcaseID) {
                     $item = $this->tcaseMgr->getLastVersionInfo($tcaseID);
@@ -1148,7 +1148,7 @@ public function addPlatformsToTestPlan(Request $request, Response $response,
                         $p2link[$plat_id] = $plat_id;
                     }
                 }
-                if (! empty($p2link)) {
+                if ($p2link !== []) {
                     $platMgr->linkToTestplan($p2link, $tplan_id);
                 }
             }

lib/api/xmlrpc/v1/xmlrpc.class.php

@@ -3001,7 +3001,7 @@ public function reportTCResult($args)
                 ));
             $targetPlatform = null;
 
-            if (! empty($platformSet)) {
+            if ($platformSet !== []) {
                 $status_ok = $this->checkPlatformIdentity(
                     $this->args[self::$testPlanIDParamName], $platformSet,
                     $msg_prefix);
@@ -3951,7 +3951,7 @@ public function addTestCaseToTestPlan($args)
                 'outputFormat' => 'mapAccessByID'
             );
             $platformSet = (array) $this->tplanMgr->getPlatforms($tplan_id, $opt);
-            $hasPlatforms = (! empty($platformSet));
+            $hasPlatforms = ($platformSet !== []);
             $hasPlatformIDArgs = $this->_isParamPresent(
                 self::$platformIDParamName);
 
@@ -8217,7 +8217,7 @@ public function getTestCaseBugs($args)
                 $targetIDs[] = $execContext['execution_id'];
             }
 
-            if (! empty($targetIDs)) {
+            if ($targetIDs !== []) {
                 $resultInfo[0]['bugs'] = array();
                 $sql = " SELECT DISTINCT bug_id FROM {$this->tables['execution_bugs']} " .
                     " WHERE execution_id in(" . implode(',', $targetIDs) . ")";

lib/execute/execHistory.php

@@ -162,7 +162,7 @@ function getCustomFields(&$tcaseMgr, &$execSet)
             $tplan_id = $execSet[$tcvid][$idx]['testplan_id'];
             $dummy = (array) $tcaseMgr->html_table_of_custom_field_values(
                 $tcvid, 'execution', null, $exec_id, $tplan_id);
-            $cf[$exec_id] = (! empty($dummy)) ? $dummy : '';
+            $cf[$exec_id] = ($dummy !== []) ? $dummy : '';
         }
     }
     return $cf;

lib/execute/execSetResults.php

@@ -411,7 +411,7 @@
             }
         }
 
-        if (! empty($stepSet)) {
+        if ($stepSet !== []) {
             // test case version under exec has steps
             $ctx = new stdClass();
             $ctx->testplan_id = $args->tplan_id;
@@ -929,7 +929,7 @@ function getTestsuiteNameDetails(&$db, $tcase_id)
                {$tables['nodes_hierarchy']} NHB
           WHERE TS.id=NHA.parent_id
           AND   NHB.id=NHA.parent_id ";
-    if (is_array($tcase_id) && ! empty($tcase_id)) {
+    if (is_array($tcase_id) && $tcase_id !== []) {
         $in_list = implode(",", $tcase_id);
         $sql .= "AND NHA.id IN (" . $in_list . ")";
     } elseif (! is_null($tcase_id)) {
@@ -1028,7 +1028,7 @@ function smartyAssignTestsuiteInfo(&$smarty, &$tree_mgr, $tcase_id, $tproject_id
             $ts_cf_smarty[$tc_id] = $cached_cf[$tsuite_id];
         }
 
-        if (! empty($a_tsval)) {
+        if ($a_tsval !== []) {
             $ckObj->value = $a_tsval[0];
             tlSetCookie($ckObj);
         }

lib/functions/cfield_mgr.class.php

@@ -24,7 +24,7 @@
 // Copied from mantis, allow load of user custom implementations
 // some sort of poor's man plugin
 $cf_files = glob(TL_ABS_PATH . "custom/cf_*.php");
-if (! empty($cf_files)) {
+if (! ($cf_files === [] || $cf_files === false)) {
     foreach ($cf_files as $inc) {
         require_once $inc;
     }
@@ -2551,10 +2551,8 @@ public function buildLocationMap($nodeType)
         $locationMap = null;
         $dummy = $this->getLocations();
         $verboseLocationCode = array_flip($dummy[$nodeType]);
-        if (! empty($verboseLocationCode)) {
-            foreach ($verboseLocationCode as $key => $value) {
-                $locationMap[$key]['location'] = $value;
-            }
+        foreach ($verboseLocationCode as $key => $value) {
+            $locationMap[$key]['location'] = $value;
         }
         return $locationMap;
     }

lib/functions/common.php

@@ -586,13 +586,11 @@ function strings_stripSlashes($parameter, $bGPC = true)
 
     if (is_array($parameter)) {
         $retParameter = null;
-        if ($parameter !== []) {
-            foreach ($parameter as $key => $value) {
-                if (is_array($value)) {
-                    $retParameter[$key] = strings_stripSlashes($value, $bGPC);
-                } else {
-                    $retParameter[$key] = stripslashes($value);
-                }
+        foreach ($parameter as $key => $value) {
+            if (is_array($value)) {
+                $retParameter[$key] = strings_stripSlashes($value, $bGPC);
+            } else {
+                $retParameter[$key] = stripslashes($value);
             }
         }
         return $retParameter;

lib/functions/exec.inc.php

@@ -172,7 +172,7 @@ function write_execution(&$db, &$execSign, &$exec_data, &$issueTracker)
             $execSet[$tcversion_id] = $execution_id;
 
             $tcvRelations = (array) $tcaseMgr->getTCVRelationsRaw($tcversion_id);
-            if (! empty($tcvRelations)) {
+            if ($tcvRelations !== []) {
                 $itemSet = array_keys($tcvRelations);
                 $tcaseMgr->closeOpenTCVRelation($itemSet,
                     LINK_TC_RELATION_CLOSED_BY_EXEC);