Applied rules:

 * ExplicitBoolCompareRector
 * TernaryToBooleanOrFalseToBooleanAndRector

Author: DanProgs

config.inc.php

@@ -2248,7 +2248,7 @@
 /**
  * Converted and derived variables (Users should not modify this section)
  */
-define('REFRESH_SPEC_TREE', $tlCfg->spec_cfg->automatic_tree_refresh ? 1 : 0);
+define('REFRESH_SPEC_TREE', $tlCfg->spec_cfg->automatic_tree_refresh !== 0 ? 1 : 0);
 define('TL_SORT_TABLE_ENGINE', $g_sort_table_engine);
 define("TL_REPOSITORY_MAXFILESIZE",
     1024 * 1024 * $tlCfg->repository_max_filesize);

firstLogin.php

@@ -33,7 +33,7 @@
 
 $message = '';
 if (! is_null($args->doEditUser)) {
-    if (strcmp($args->password, $args->password2)) {
+    if (strcmp($args->password, $args->password2) !== 0) {
         $message = lang_get('passwd_dont_match');
     } else {
         $user = new tlUser();

install/installNewDB.php

@@ -474,7 +474,7 @@
     }
 }
 
-if ($update_pwd) {
+if ($update_pwd !== 0) {
     echo "Password Conversion ...";
     // @author Francisco Mancardi - 20050918
     // Found error upgrading from 1.0.4 to 1.6 on RH

lib/api/rest/v2/tlRestApi.class.php

@@ -1692,7 +1692,7 @@ public function updateBuild($id)
                     $oio = intval($build['is_open']);
                     $nio = intval($item->is_open);
                     if ($oio != $nio) {
-                        if ($nio) {
+                        if ($nio !== 0) {
                             $this->buildMgr->setOpen($id);
                         } else {
                             $this->buildMgr->setClosed($id);

lib/api/rest/v3/RestApi.class.php

@@ -836,7 +836,7 @@ public function updateBuild(Request $request, Response $response, $args)
                     $oio = intval($build['is_open']);
                     $nio = intval($item->is_open);
                     if ($oio != $nio) {
-                        if ($nio) {
+                        if ($nio !== 0) {
                             $this->buildMgr->setOpen($id);
                         } else {
                             $this->buildMgr->setClosed($id);

lib/api/xmlrpc/v1/sample_clients/php/clientTestSuiteTestCaseStepsManagement.php

@@ -31,7 +31,7 @@
 for ($idx = 1; $idx < $qtySteps; $idx ++) {
     $action = 'FULL STOP NOW!!!! - intensity=';
     $expected_results = '%s Red Lights ON';
-    if ($idx & 1) {
+    if (($idx & 1) !== 0) {
         $action = 'Start Server with power=';
         $expected_results = 'GREEN Lantern %s ON';
     }

lib/api/xmlrpc/v1/xmlrpc.class.php

@@ -1882,7 +1882,7 @@ public function getLastExecutionResult($args)
                     $targetID;
                 $resultInfo[0] = $this->dbObj->fetchFirstRow($sql);
 
-                if ($options->getBugs) {
+                if ($options->getBugs !== 0) {
                     $resultInfo[0]['bugs'] = array();
                     $sql = " SELECT DISTINCT bug_id FROM {$this->tables['execution_bugs']} " .
                         " WHERE execution_id = " . $targetID;
@@ -2029,7 +2029,7 @@ public function getAllExecutionsResults($args)
                     $sql = "SELECT * FROM {$this->tables['executions']} WHERE id=" .
                         $tcExecId;
                     $resultInfo[$tcExecId] = $this->dbObj->fetchFirstRow($sql);
-                    if ($options->getBugs) {
+                    if ($options->getBugs !== 0) {
                         $resultInfo[$tcExecId]['bugs'] = array();
                         $sql = " SELECT DISTINCT bug_id FROM
                        {$this->tables['execution_bugs']}
@@ -5480,15 +5480,15 @@ protected function checkPlatformIdentity($tplanID, $platformInfo = null,
             $messagePrefix);
         $status = $name_exists | $id_exists;
 
-        if (! $status) {
+        if ($status === 0) {
             $pname = self::$platformNameParamName . ' OR ' .
                 self::$platformIDParamName;
             $msg = $messagePrefix .
                 sprintf(MISSING_REQUIRED_PARAMETER_STR, $pname);
             $this->errors[] = new IXR_Error(MISSING_REQUIRED_PARAMETER, $msg);
         }
 
-        if ($status) {
+        if ($status !== 0) {
             // get test plan name is useful for error messages
             $tplanInfo = $this->tplanMgr->get_by_id($tplanID);
             if (is_null($platformInfo)) {
@@ -9663,7 +9663,7 @@ public function getExecutionSet($args)
             $sql .= ")";
 
             $sql .= " ORDER BY id ";
-            $sql .= ($opt->getOrderDescending) ? " DESC" : " ASC";
+            $sql .= ($opt->getOrderDescending !== 0) ? " DESC" : " ASC";
 
             $rs = $this->dbObj->fetchRowsIntoMap($sql, 'id');
             if (is_null($rs)) {

lib/cfields/cfieldsEdit.php

@@ -63,7 +63,7 @@
         break;
 }
 
-if ($do_control_combo_display) {
+if ($do_control_combo_display !== 0) {
     $keys2loop = $cfield_mgr->get_application_areas();
     foreach ($keys2loop as $ui_mode) {
         $cfieldCfg->cf_enable_on[$ui_mode]['value'] = 0;

lib/events/eventviewer.php

@@ -237,7 +237,7 @@ function getFilters(&$argsObj = null, $dateFormat = null)
 
         if (! is_null($argsObj->testers)) {
             $filters->users = implode(",", $argsObj->testers);
-            if (! $filters->users) {
+            if ($filters->users === '' || $filters->users === '0') {
                 $filters->users = null;
             }
         }

lib/execute/execSetResults.php

@@ -70,7 +70,7 @@
 $attachmentInfos = null;
 
 $do_show_instructions = ($args->level == "" || $args->level == 'testproject') ? 1 : 0;
-if ($do_show_instructions) {
+if ($do_show_instructions !== 0) {
     show_instructions('executeTest');
     exit();
 }
@@ -628,7 +628,7 @@ function initArgs(&$dbHandler, $cfgObj)
     $args->doMoveNext = isset($_REQUEST['move2next']) ? 1 : 0;
 
     $args->doMovePrevious = isset($_REQUEST['move2previous']) ? $_REQUEST['move2previous'] : 0;
-    $args->moveTowards = $args->doMoveNext ? 'forward' : ($args->doMovePrevious ? 'backward' : null);
+    $args->moveTowards = $args->doMoveNext !== 0 ? 'forward' : ($args->doMovePrevious ? 'backward' : null);
 
     // can be a list, will arrive via form POST
     $args->tc_versions = isset($_REQUEST['tc_version']) ? $_REQUEST['tc_version'] : null;
@@ -762,7 +762,7 @@ function initArgs(&$dbHandler, $cfgObj)
     $args->ctsCfg = null;
     $cts = null;
 
-    if ($args->codeTrackerEnabled = intval($info['code_tracker_enabled'])) {
+    if (($args->codeTrackerEnabled = intval($info['code_tracker_enabled'])) !== 0) {
         $ct_mgr = new tlCodeTracker($dbHandler);
         $args->ctsCfg = $ct_mgr->getLinkedTo($args->tproject_id);
         $cts = $ct_mgr->getInterfaceObject($args->tproject_id);
@@ -1240,7 +1240,7 @@ function setTesterAssignment(&$db, $exec_info, &$tcaseMgr, $tplan_id,
         if (! is_null($p3)) {
             foreach ($p3[$version_id][$platform_id] as $uu) {
                 $assignedTesterId = intval($uu['user_id']);
-                if ($assignedTesterId) {
+                if ($assignedTesterId !== 0) {
                     $user = tlUser::getByID($db, $assignedTesterId);
                     if ($user) {
                         $exec_info[$version_id]['assigned_user'][] = $user->getDisplayName();