Skip to content

Add save test script to collection database#35

Closed
biocodeit wants to merge 1 commit intoDancode-188:mainfrom
biocodeit:chore/addPostScriptToCollectionDB
Closed

Add save test script to collection database#35
biocodeit wants to merge 1 commit intoDancode-188:mainfrom
biocodeit:chore/addPostScriptToCollectionDB

Conversation

@biocodeit
Copy link
Copy Markdown
Contributor

the project often requires the script to be saved to the collection.

the project often requires the script to be saved to the collection.
Copy link
Copy Markdown
Owner

@Dancode-188 Dancode-188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @biocodeit,

Thank you for this contribution. I really appreciate you adding the ability to save test scripts to collections.

I just merged PR #36 which fixes the critical crash bug you reported in issue #32 - that should unblock you from writing more tests!

Since both PRs modify RequestBuilder.tsx, there will be merge conflicts that need to be resolved. Could you please:

  1. Pull the latest changes from main:
git checkout main
git pull origin main
  1. Rebase your branch on the updated main:
git checkout <your-branch-name>
git rebase main
  1. Resolve any merge conflicts that arise
  • The conflicts should be minimal and in different areas of the file
  • Your changes are around lines 255 and 488
  • The new changes are around lines 214 and 549-617
  1. Force push the rebased branch:
git push --force-with-lease

Once the conflicts are resolved, I'll review and merge this PR. Let me know if you need any help with the rebase process!

Thanks again for contributing! 🚀

@Dancode-188
Copy link
Copy Markdown
Owner

Hey @biocodeit,

The postScript feature you added here is now in #41 along with comprehensive tests for it.

This was the starting point for the whole series of PRs that followed - #37, #40, and #41 all built on top of this foundation. The feature itself is straightforward and works correctly, it just needed the test coverage and organization that came in the later PRs.

Closing as superseded by #41, which includes these changes plus everything else.

Thanks for sticking with this through multiple iterations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants