fix: correct continueOnError logic in chain execution, fixes #10#43
Merged
Dancode-188 merged 1 commit intomainfrom Dec 27, 2025
Merged
fix: correct continueOnError logic in chain execution, fixes #10#43Dancode-188 merged 1 commit intomainfrom
Dancode-188 merged 1 commit intomainfrom
Conversation
The continueOnError flag was inverted - chains would stop when they should continue and vice versa. The skip-and-break logic was executing outside the conditional block, causing it to run when continueOnError was true. Moved the skip-and-break logic inside the !step.continueOnError block so remaining steps are only skipped when we should stop on error. Also fixed several TypeScript errors that were preventing builds: - Added missing time/size properties to HttpClientResponse - Fixed method return types and null checks in e2e object models - Corrected Dexie update() calls to use proper UpdateSpec format - Fixed import paths for Collection type - Added @types/dotenv dependency
Owner
Author
|
Fix looks correct - skip/break logic now only runs when continueOnError is false, as intended. Build passes clean. The TypeScript fixes were necessary to get the build working, should have been caught earlier. Will need manual testing with actual chain executions before we can fully close #10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10
Problem
The continueOnError flag was inverted. When set to true, chains would mark remaining steps as skipped and stop instead of continuing to the next step.
Root cause: the skip-and-break logic at lines 236-240 was running outside the conditional block, so it executed when continueOnError was true.
Changes
Moved the skip-and-break logic inside the
!step.continueOnErrorblock so it only runs when we should stop on error.Also cleaned up several TypeScript errors that were blocking builds:
Build verified passing.