fix: throw error instead of silent return in cancelExecution, fixes #11#44
Merged
Dancode-188 merged 1 commit intomainfrom Dec 27, 2025
Merged
Conversation
The cancelExecution method would silently return when an execution wasn't found or wasn't in running status, providing no feedback to the caller. Changed to throw descriptive errors: - Execution not found: throws with execution ID - Wrong status: throws with current status This gives callers proper error handling instead of silent failures. Note: Cancellation persistence (#13) is already handled by the existing db.chainExecutions.update() call at lines 324-328.
Owner
Author
|
Straightforward fix. The error messages are clear and will make debugging much easier. Build verified passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11
Problem
cancelExecution would silently return when the execution didn't exist or wasn't in running status. No error, no feedback - just nothing. Makes debugging issues nearly impossible.
Changes
Replaced the silent return with proper error throwing:
Error: Execution {id} not foundError: Cannot cancel execution with status: {status}Notes
Issue #13 (persistence) is already handled by the existing
db.chainExecutions.update()call - cancellation is being persisted correctly.