Added core support for message_to_radio#1
Open
DanielEdriPurpl wants to merge 8 commits intomasterfrom
Open
Conversation
kantera800
reviewed
Jul 29, 2020
kantera800
reviewed
Jul 29, 2020
kantera800
reviewed
Jul 29, 2020
kantera800
reviewed
Jul 29, 2020
kantera800
reviewed
Jul 29, 2020
kantera800
reviewed
Jul 29, 2020
kantera800
reviewed
Jul 29, 2020
kantera800
reviewed
Jul 29, 2020
common/beerocks/tlvf/yaml/beerocks/tlvf/beerocks_message_bml.yaml
Outdated
Show resolved
Hide resolved
DanielEdriPurpl
force-pushed
the
dev_daniel_task_01
branch
2 times, most recently
from
7bd4876 to
816ea23
Compare
DanielEdriPurpl
changed the title
DanielEdriPurpl
force-pushed
the
dev_daniel_task_01
branch
from
816ea23 to
6bd4bf7
Compare
kantera800
reviewed
Aug 2, 2020
kantera800
reviewed
Aug 2, 2020
kantera800
reviewed
Aug 2, 2020
There was a problem hiding this comment.
1st commit:
- message: better to use something like this
preparation commit.
message used for .....
-title: is too long, should be 72 characters per line (you should see warning in vs code gui)
should include also location of the changes
yaml: bml: add exercise CMDUs & structs
rest of commits:
- if you have changes all over the project the order of the commits should look like this:
yaml: bml: add CMDUs
bml: use CMDUs
yaml: controller: add CMDUs
controller: use CMDUs
yaml: agent: add CMDUs
agent: use CMDUs
Preparation commit This message is used to send an 'acknowledgment' of some sort from a controller towards its radios
Implementation of the CMDUs declared in the previous commit
This commit adds the control CMDUs for 'message_to_radio'
This commit uses the CMDUs declared in the previous commit
This commit uses the CMDUs declared in the latest declarative commit, but on the agent
This adds a test to the test_flow.py script
DanielEdriPurpl
force-pushed
the
dev_daniel_task_01
branch
from
097b3d5 to
b0a0242
Compare
This commit removes the 60ghz references in both .yaml files and the auto generated alike
This commit removes the unsupported 60ghz references from the controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.