fix(sort): replace Element::cmp with key-based comparison to ensure total ordering#31
Closed
cohenna wants to merge 1 commit intoDanielT:mainfrom
Closed
fix(sort): replace Element::cmp with key-based comparison to ensure total ordering#31cohenna wants to merge 1 commit intoDanielT:mainfrom
cohenna wants to merge 1 commit intoDanielT:mainfrom
Conversation
…otal ordering Rust 1.92's stricter sort checking panics when the comparison function violates total ordering requirements. The Element::cmp implementation had two issues: 1. PartialEq used pointer comparison while Ord used content comparison 2. Natural sorting was applied inconsistently, breaking transitivity Replace the `elem_a.cmp(elem_b)` call in ElementRaw::sort() with a custom key-based comparison that provides a consistent total order: - INDEX sub-element (numeric, for BSW elements) - Item name with natural sorting via (base, number, name) tuple - Definition ref (for BSW elements without names) - First child character data (for reference elements) Also remove the nested workspace in autosar-data/Cargo.toml to fix "multiple workspace roots" build error.
Owner
|
Hi, thanks for the pull request. Some remarks:
|
Owner
|
This seems abandoned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust 1.92's stricter sort checking panics when the comparison function violates total ordering requirements. The Element::cmp implementation had two issues:
Replace the
elem_a.cmp(elem_b)call in ElementRaw::sort() with a custom key-based comparison that provides a consistent total order:Also remove the nested workspace in autosar-data/Cargo.toml to fix "multiple workspace roots" build error.